Bugzilla – Full Text Bug Listing
| Summary: | [publisher] EquinoxExecutableAction should create for macos a symlink to the executable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Hugues Malphettes <hmalphettes> | ||||||
| Component: | p2 | Assignee: | Tobias Oberlies <t-oberlies> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | bugs.eclipse.org, irbull, jeffmcaffer, mail, pascal, steffen.pingel | ||||||
| Version: | 3.6 | ||||||||
| Target Milestone: | Juno M7 | ||||||||
| Hardware: | Macintosh | ||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 331974 | ||||||||
| Attachments: |
|
||||||||
Created attachment 171305 [details]
One liner to create the symbolic link to the executable for macosx
Sorry I got confused and attached the wrong patch when I filed the bug.
Tobias, could you please look into releasing this for RC1. Thx. Unfortunately, I have no way of testing the patch: I can't do a manual test (which would at least require a *nix OS), and I don't know of any integration test chaining up an EquinoxExecutableAction with a director call. And I don't feel in the position of applying this blindly. One more minor thing (which is not really an issue): The patch doesn't apply to HEAD because EquinoxExecutableAction moved to /org.eclipse.equinox.p2.publisher.eclipse/src/org/eclipse/equinox/p2/publisher/eclipse/EquinoxExecutableAction.java. Move all 3.8 bugs to Juno. @Hugues: Thank you for the patch. I've applied it to master. IMHO, the right thing to verify the patch would be an integration test in p2, i.e. a product publisher call followed by an engine call. However AFAIK these kind of tests don't exist yet, and so this would be significantly more effort than the patch itself. As fallback, I'll be testing the patch in integration in Tycho together with bug 349877 once the change makes it into the next I-build. (In reply to comment #5) > As fallback, I'll be testing the patch in integration in Tycho together with bug > 349877 once the change makes it into the next I-build. Done. |
Created attachment 171300 [details] One extra line to generate the symbolic link for macosx When EquinoxExecutableAction generates the native touchpoint to setup the executable for maxcosx, it should also generate a symbolic link to the executable. Symbolic links don't survive a zip. So it has to be generated via the native touchpoint.