Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316025

Summary:

Spell check does not work for HTML Editor and Web Page Editor

Product:

[WebTools] WTP Source Editing

Reporter:

Mark A. Ziesemer <bugs>

Component:

wst.html

Assignee:

Rakesh <rakes123>

Status:

RESOLVED FIXED

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

major

Priority:

CC:

nsand.dev, rakes123, thatnitind

Version:

3.2

Flags:

nsand.dev: review+

Target Milestone:

3.2.2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Patch	nsand.dev: iplog+

Description Mark A. Ziesemer

2010-06-07 12:31:20 EDT

Build Identifier: 20100603-0907

I have reproduced consistently with eclipse-jee-helios-RC3-win32-x86_64.zip , as well with both eclipse-SDK-3.6RC4-win32-x86_64.zip and eclipse-SDK-3.6RC1-win32-x86_64.zip , after installing the Web Page Editor and Eclipse Web Developer Tools.  I have not been able to reproduce with eclipse-SDK-3.5.2-win32-x86_64.zip .

No errors or warnings are visible in the Eclipse Error Log.

Spell checking is enabled in the Eclipse Preferences under General/Editors/Text Editors/Spelling, with the "English (United States)" platform dictionary selected.  Additional selection of a user defined dictionary does not appear to have any impact.

Reproducible: Always

Steps to Reproduce:
1. Download and extract a given Eclipse 3.6 RC.  Either use a "
Eclipse IDE for Java EE Developers" package (e.g. eclipse-jee-helios-RC3-win32-x86_64.zip), or use a classic package (e.g. eclipse-SDK-3.6RC4-win32-x86_64.zip), then install the Web Page Editor and Eclipse Web Developer Tools through the update manager.  I used a new workspace for each version.
2. Create a new project, either a Java Project or just a general "Project".
3. Add a new file into the project called Test.htm, with content of "Spellling errorrs" or other misspellings.
4. Open the file with the Text Editor, and observe that the spelling errors are properly detected and underlined almost instantly (< 2 seconds).
5. Open the same file with the HTML Editor, and observe that the spelling errors are NOT being detected and underlined.
6. Open the same file with the Web Page Editor, and observe that the spelling errors are NOT being detected and underlined.

Comment 1 Nitin Dahyabhai

2010-06-07 12:45:47 EDT

Comments are spell checked.

Comment 2 Mark A. Ziesemer

2010-06-07 13:03:02 EDT

Confirmed that comments are being spell checked.  However, HTML content (text, not tags) is not being spell checked.  This was working in 3.5, but no longer in 3.6.  This is necessary to prevent spelling errors from appearing within web pages as they are written.  Something has certainly broken or changed.  If this has changed, is it documented somewhere?

Also confirmed that the issue is reproducible using eclipse-jee-helios-RC3-win32.zip under Windows XP.

Comment 3 Rakesh

2010-06-11 04:01:58 EDT

Created attachment 171698 [details]
Patch

SpellcheckDelegateAdapterFactory allows spellcheck only for comments.It should allow spellcheck for text too.

Comment 4 Nitin Dahyabhai

2010-06-11 10:20:26 EDT

In HTML, yes, in XML, no.

Comment 5 Nick Sandonato

2010-06-11 11:15:38 EDT

(In reply to comment #4)
> In HTML, yes, in XML, no.

In previous versions, XML content was spell checked for XML documents. This seems like the appropriate fix to me.

Comment 6 Mark A. Ziesemer

2010-06-15 00:05:30 EDT

Since I'm sure this can no longer make the 3.6 release, can someone help me create a patch for this for use on multiple workstations?  I already have the org.eclipse.wst.xml.ui project downloaded from CVS, patched, and built as a plug-in .jar.  However, with P2, I no longer can just increment the version and drop it into the Eclipse plug-ins folder.  I tried following the instructions at http://aniefer.blogspot.com/2009/06/patching-features-with-p2.html for creating a feature patch, but there seems to be a number of missing steps.

Comment 7 Nitin Dahyabhai

2010-07-26 11:33:14 EDT

*** Bug 320771 has been marked as a duplicate of this bug. ***

Comment 8 Nick Sandonato

2010-08-16 15:56:55 EDT

Resolved in the next service release of WTP.

Comment 9 Nick Sandonato

2010-08-16 16:17:54 EDT

(In reply to comment #6)
> Since I'm sure this can no longer make the 3.6 release, can someone help me
> create a patch for this for use on multiple workstations?  I already have the
> org.eclipse.wst.xml.ui project downloaded from CVS, patched, and built as a
> plug-in .jar.  However, with P2, I no longer can just increment the version and
> drop it into the Eclipse plug-ins folder.  I tried following the instructions
> at http://aniefer.blogspot.com/2009/06/patching-features-with-p2.html for
> creating a feature patch, but there seems to be a number of missing steps.

Hi Mark, are you patching with the org.eclipse.wst.xml_ui.feature?

Comment 10 Mark A. Ziesemer

2010-08-16 17:55:44 EDT

Nick - yes, I had, though it all seems a little bit confusing yet.  However, I know I had it working.  But now, even more confusingly, it seems that my patch is no longer necessary.  Not understanding the version #'s between WTP and Eclipse, it appears that this is now fixed in 20100617-1415 ?