Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 316006

Summary: Modify ARM and MX4J version numbers to match released version
Product: z_Archived Reporter: Joel Cayne <jcayne>
Component: TPTPAssignee: Joel Cayne <jcayne>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: normal    
Priority: P2 CC: ewchan, jcayne, jgwest, samwu, slamers
Version: unspecifiedFlags: kathy: pmc_approved? (oec)
kathy: pmc_approved? (ernest)
kathy: pmc_approved? (kathy)
kathy: pmc_approved? (paulslau)
jgwest: pmc_approved+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Modifies version number for org.opengroup.arm
none
Modifies version number for org.mx4j.jmx
none
Patch for including jars none

Description Joel Cayne CLA 2010-06-07 11:07:45 EDT 
The third party bundles org.mx4j.jmx (dev.eclipse.org:/cvsroot/tptp/monitoring/org.mx4j.jmx) and org.opengroup.arm (dev.eclipse.org:/cvsroot/tptp/trace/org.opengroup.arm) had their plug-in Manifest.mf version number updated when maintenance was performed on the plug-ins. The third party jars and version did not change so the plug-in version should be updated to match the third party version. The qualifier update could be used to indicate a change in the packaging (e.g. Bundle-RequiredExecutionEnvironment, Bundle-Vendor, etc.) similar to what is done in Orbit.

As indicated in their corresponding about.html files to match the third party version:
org.mx4j.jmx should change the packaging version number to 3.0.1 from 3.1.0
org.opengroup.arm should change the packaging version number to 4.0.0 from 4.1.0
Comment 1 Joel Cayne CLA 2010-06-07 11:14:41 EDT 
Created attachment 171280 [details]
Modifies version number for org.opengroup.arm
Comment 2 Joel Cayne CLA 2010-06-07 11:15:21 EDT 
Created attachment 171281 [details]
Modifies version number for org.mx4j.jmx
Comment 3 Joel Cayne CLA 2010-06-07 11:15:37 EDT 
Sean,
Can you please review?

Thanks!
Comment 4 Sean Lamers CLA 2010-06-07 11:25:00 EDT 
Patches look good!
Comment 5 Joel Cayne CLA 2010-06-07 11:41:10 EDT 
I would like to request PMC approval to include the following fix in TPTP
4.7.0.

1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

Modifies the org.mx4j.jmx and org.opengroup.arm plug-in version to match the third party bundle version.

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

3. Is this a regression or API breakage? Explain.

No.

4. Does this require new API?

No.

5. Who performed the code review?

Sean

6. Is there a test case attached to the bugzilla record?

n/a

7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

A fresh install will cleanly pick up this version of the third party bundles. Updating an existing installation would not pick up this version of the As-Is monitoring components due to the plug-in version increase. Depending on the previously installed version, packaging or plug-in modifications (such as Bundle Vendor, Execution Environment, TPTP feature image) would not be applied, however, the version of the installed third party jar would be the same.

8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?
n/a
Comment 6 Kathy Chan CLA 2010-06-07 12:07:41 EDT 
This change is required to have the version of the plugin matching that in the 3rd party JAR and what's been approved in the CQ (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=306 and https://dev.eclipse.org/ipzilla/show_bug.cgi?id=307).

Requesting approval for TPTP 4.7.
Comment 7 Joel Cayne CLA 2010-06-07 13:11:52 EDT 
Patch for ARM checked into HEAD.
Comment 8 Joel Cayne CLA 2010-06-07 21:53:45 EDT 
Patch for MX4J was checked into HEAD.
Comment 9 Joel Cayne CLA 2010-06-08 16:14:58 EDT 
Created attachment 171468 [details]
Patch for including jars

Patch to include third party jars in output.
Comment 10 Sean Lamers CLA 2010-06-08 16:27:40 EDT 
Patch looks good. It might be possible to remove the copyright to be consistent with what was packaged previously.
Comment 11 Joel Cayne CLA 2010-06-08 16:28:27 EDT 
Patch checked into HEAD.
Comment 12 Joel Cayne CLA 2010-06-11 10:28:35 EDT 
Verified on TPTP-4.7.0RC4-201006081927.