Bug 315986

Comment 1 Sebastian Zarnekow 2010-06-25 11:34:47 EDT

Is this caused by missing entries in the build.properties?

Comment 2 Mirko Seifert 2010-06-25 15:06:40 EDT

I'm not sure how the xText plug-ins are packaged, but if the packaging works similar to the "Export Deployable Plug-ins and Fragments" function in Eclipse then the problem is most probably a missing entry in the build.properties. 

I did not look at the packaged JARs to check whether these do contain the genmodel. If they do indeed contain the genmodel files, the paths to the genmodels in the plugin.xml might be wrong as well.

Comment 3 Sebastian Zarnekow 2010-07-20 07:35:02 EDT

I identified some missing entries in build.properties files and some wrong genmodel uris in plugin.xml files. Is there a way to validate the latter automatically?

Please verify the fix.

Comment 4 Mirko Seifert 2010-07-20 08:17:38 EDT

I've checked out Xtext from the CVS head, but there are still Genmodels which can't be found. I'll attach a JUnit Plug-in Test to verify the problem.

Comment 5 Mirko Seifert 2010-07-20 08:18:31 EDT

Created attachment 174735 [details]
A test case that detects incorrectly registed genmodels

Comment 6 Sebastian Zarnekow 2010-07-20 08:51:45 EDT

Does it work with a deployed version of a freshly build Xtext?

Comment 7 Mirko Seifert 2010-07-20 08:53:51 EDT

Where can I get one of those?

Comment 8 Sebastian Zarnekow 2010-07-20 08:55:19 EDT

build.eclipse.org seems to be down (again).
Export as -> Deployable .. ?

Comment 9 Mirko Seifert 2010-07-20 15:08:24 EDT

I've exported all Xtext plug-ins to a separate Eclipse installation, but the result is the same. The following GenModels are not found:

platform:/plugin/org.eclipse.xtext/model/xtext.genmodel
(registered in org.eclipse.xtext/plugin.xml, model is actually in src/org/eclipse/xtext/Xtext.genmodel)

platform:/plugin/org.eclipse.xtext.xbase/org/eclipse/xtext/xbase/Xbase.genmodel
(registered three times in org.eclipse.xtext.xbase/plugin.xml, model is actually in model/Xbase.genmodel)

platform:/plugin/org.eclipse.xtext.builder/model/BuilderState.genmodel
(registered in org.eclipse.xtext.builder/plugin.xml, model folder is missing from build.properties file)

Comment 10 Sebastian Zarnekow 2010-07-21 03:40:59 EDT

I'm pretty sure that I fixed these wrong / missing entries in the plugin.xml / build.properties with yesterdays commit.

See here: http://git.softeys.de/tmf.xtext.git/commitdiff/533bc568b9afe84070c385925ef6aaf21daa9356

Can you confirm that you are working with the latest version from Xtext CVS HEAD?

Comment 11 Mirko Seifert 2010-07-21 04:01:49 EDT

Ok, I performed another update and the test case succeeds for the deployed version of the plug-ins. It fails when running the test case from the workspace containing the source version of the plug-ins, because the paths to the GenModels differ, but this is not a problem for users of Xtext.

Comment 12 Sebastian Zarnekow 2010-07-21 04:03:12 EDT

Thanks for double-checking.

Comment 13 Karsten Thoms 2017-09-19 16:17:07 EDT

Closing bug which were set to RESOLVED before Eclipse Neon.0.