Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315914

Summary:

"Add Element" popup should only show the elements allowed at the current cursor position

Product:

z_Archived

Reporter:

Florian Thienel <florian>

Component:

Mylyn

Assignee:

Florian Thienel <florian>

Status:

CLOSED FIXED

QA Contact:

David Williams <david_williams>

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Prototype (without tests)	none
mylyn/context/zip	none

Description Florian Thienel

2010-06-06 18:37:54 EDT

Is:
The current implementation of the  "Add Element" popup shows a lot more elements than allowed at the current cursor position.

Should:
Only the elements that are allowed at the current cursor position should be shown in the popup.

Comment 1 Holger Voormann

2010-06-07 18:27:04 EDT

Created attachment 171346 [details]
Prototype (without tests)

The same is true for "Convert Element" popup.

Maybe this could be done in VexWidgetImpl.getValidInsertElements() (see attachment) and  getValidMorphElements().

Comment 2 Florian Thienel

2010-06-17 16:56:26 EDT

The patch looks fine. I'll see how to test this.

Comment 3 Florian Thienel

2010-06-17 17:55:20 EDT

I applied your patch and added a test for it.

Comment 4 Florian Thienel

2010-06-17 17:55:22 EDT

Created attachment 172165 [details]
mylyn/context/zip

Comment 5 Florian Thienel

2011-06-02 05:25:52 EDT

Closing resolved bugs.

Comment 6 Florian Thienel

2011-11-09 17:37:54 EST

Moved to Mylyn Docs Vex.