Bugzilla – Full Text Bug Listing
| Summary: | [LTTng] HistogramView improvements | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Francois Chouinard <fchouinard> | ||||
| Component: | LinuxTools | Assignee: | Francois Chouinard <fchouinard> | ||||
| Status: | CLOSED FIXED | QA Contact: | Francois Chouinard <fchouinard> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Francois Chouinard
Created attachment 174163 [details]
Histogram patch
The null verification has been added to the displayModel (ControlFlowView.java) function.
To prevent the Null Pointer Exception caused by clicking on Control Flow with no active experiment.
The null verification has been added to the notifyParentUpdatedInformation (ChildrenHistogramCanvas.java) function.
To prevent the Null Pointer Exception caused by clicking on Child Histogram with no active experiment.
The null verification has been added to the asynchronousRedraw, asynchronousNotifyParentSelectionWindowChanged, asynchronousNotifyParentUpdatedInformation (HistogramCanvas.java) functions.
To prevent the Null Pointer Exception caused by clicking on Histograms with no active experiment.
The null verification has been added to the mouseMove, mouseDown, mouseUp, receiveMouseScrollCount (HistogramCanvasMouseListener.java) functions.
To prevent the Null Pointer Exception caused by clicking on Full Histogram with no active experiment.
The null verification has been added to the updateSelectedWindowTimestamp, updateSelectedWindowInformation, updateFullExperimentInformation, timeTextGroupChangeNotification, windowChangedNotification, performSelectedWindowEventsRequest, currentTimeUpdated (HistogramView.java) functions.
To prevent the Null Pointer Exceptions.
The recalculateElementsTimeInterval function call has been removed from resetTable (HistogramVontent.java) because il already called in resetTable function.
The Histogram Heritage model has been improved: the listeners have been moved from base class (HistogramCanvas) to child classes (ChildrenHistogramCanvas and ParentHistogramCanvas). The not used listeners have been eliminated in Child Histogram such as: MouseListener, Focus Listener, Key Listener.
Improvements
The Histogram Canvas Control Listeners Heritage model has been improved: the new ParentHistogramCanvasControlListener class related to the Full Histogram Canvas Control Listener has been added. It contents the setWindowCenterPosition in controlResized which has been removed from HistogramCanvasControlListener related to the small diagram which does not have the selection window.
The Histogram View UI has been improved: the dynamic height has been added to Full Histogram; the histograms and the time range controls and indicators position have been changed for reason to use full window space; the code has been optimized and regrouped to ease the future corrections and comprehension.
Comment on attachment 174163 [details]
Histogram patch
Patch committed
Fixed Delivered with 0.7 |