Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315877

Summary:

[Discovery] Zookeeper and localfile do not include discovery feature

Product:

[RT] ECF

Reporter:

Wim Jongman <wim.jongman>

Component:

ecf.discovery

Assignee:

ecf.core-inbox <ecf.core-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

bugs.eclipse.org, slewis

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
P2 Update screen	none
patch	none
mylyn/context/zip	none

Description Wim Jongman

2010-06-05 10:39:52 EDT

zeroconf includes the base discovery feature. zookeeper and localfile do not. Need they be included?

Comment 1 Wim Jongman

2010-06-05 10:48:32 EDT

Created attachment 171196 [details]
P2 Update screen

Comment 2 Wim Jongman

2010-06-05 10:58:38 EDT

Created attachment 171197 [details]
patch

I thought I patched that b.a. I didn't. Need to include feature o.e.d.feature. Can I get an ok for this patch before rc4?

Comment 3 Scott Lewis

2010-06-05 12:11:11 EDT

+1 for this change.  Wim please let all know here on this bug whether you release the change to HEAD or you wish me to do so.  Thanks.

Comment 4 Wim Jongman

2010-06-05 17:13:29 EDT

released to HEAD

Comment 5 Wim Jongman

2010-06-05 17:13:31 EDT

Created attachment 171207 [details]
mylyn/context/zip

Comment 6 Wim Jongman

2010-06-05 17:15:03 EDT

and FIXED

Comment 7 Markus Kuppe

2010-06-06 05:28:28 EDT

IMO all discovery feature may use require instead of include. E.g. include causes the build to rebuild "o.e.e.discovery.feature" rather than consume it while there is no advantage of using include over require with p2.

We should wait with this change for after Helios though.