Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315827

Summary:

Found a JpaProject leak in the JpaDetailsView

Product:

[WebTools] Dali JPA Tools

Reporter:

Karen Butzke <karenfbutzke>

Component:

General

Assignee:

Karen Butzke <karenfbutzke>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

neil.hauge

Version:

2.3

Flags:

neil.hauge: review+

Target Milestone:

2.3.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
proposed patch against head	none

Description Karen Butzke

2010-06-04 15:43:31 EDT

1. Open 1 Java Entity in the editor and view it in the Jpa Details view.
2. Close the Java editor.
3. Close the Project.  

The cached PersistentTypeDetailsPage in JpaDetailsView still contains the PerssitentType subject, thus the JpaProject is still hanging around.

The issue is that the PersistentTypeDetailsPage subject is not set to null when the editor is closed.

I tested this in debug by putting a breakpoint in JpaDetailsView.dispose and after step 3 I closed the JpaDetailsView and dug into the cache of details pages. Was also able to see the GenericJavaPersistentType2_0 object hanging around referenced by the PersistentTypeDetailsPage using the sun JDK leak tools that Brian mentioned recently.

Comment 1 Karen Butzke

2010-06-17 18:00:13 EDT

Created attachment 172166 [details]
proposed patch against head

Comment 2 Karen Butzke

2010-06-24 14:48:42 EDT

resolved in HEAD for 2.3.1 maintenance

Comment 3 Karen Butzke

2010-07-23 15:31:46 EDT

manually verified this in debug as described in the bug description