Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315780

Summary: [SysML] Papyrus shall support SysML Requirement diagram
Product: [Modeling] Papyrus Reporter: Hubert Dubois <hubert.dubois>
Component: CoreAssignee: Project Inbox <mdt-papyrus-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: klaas.gadeyne, Monica22Hicks, yann.tanguy
Version: 0.7.0   
Target Milestone: 0.7.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 351973, 329757, 329758, 329760, 329774, 329775, 329776, 329780, 395484    
Bug Blocks:    
Attachments:
Description Flags
Modifications and updates (cf. comments)
none
Preferences modifications
none
Some addings
none
Corrections
none
Bug corrections
none
Correction of inherited element edit part provider
none
Corrections
none
Corrections
none
Corrections for Reqs Diagram
none
adding of comments and constraints elements.
none
Management of Link for Comments, constraints and Trace Links
none
Corrections of errors
none
new requirement Plugin by using a generative approach none

Description Hubert Dubois CLA 2010-06-04 11:06:00 EDT
Papyrus shall support SysML Requirement diagram
Comment 1 Patrick Tessier CLA 2010-06-04 11:14:50 EDT
the code has been committed from the patch of Hubert Dubois (CEA LIST)
the version number is 1811
Comment 2 Yann Tanguy CLA 2010-06-09 05:02:15 EDT
Diagram icon update (done in r1857).
Comment 3 Yann Tanguy CLA 2010-07-07 08:51:47 EDT
Task reopened : Diagram not functional yet.
Comment 4 Hubert Dubois CLA 2010-07-07 09:13:00 EDT
- comment of plugin.xml
- adding of edit parts providers for named element management
- update of providers for containment management (remove of unused providers and adding of new ones)
Comment 5 Hubert Dubois CLA 2010-07-07 09:14:23 EDT
Created attachment 173645 [details]
Modifications and updates (cf. comments)

cf comments.
Comment 6 Yann Tanguy CLA 2010-07-07 09:24:40 EDT
Patch https://bugs.eclipse.org/bugs/attachment.cgi?id=173645 commit in r2275.
Comment 7 Hubert Dubois CLA 2010-07-07 11:09:57 EDT
Created attachment 173662 [details]
Preferences modifications
Comment 8 Hubert Dubois CLA 2010-07-07 11:10:31 EDT
Modification of the general Preferences for inherited elements usage.
Comment 9 Yann Tanguy CLA 2010-07-07 11:55:15 EDT
Patch https://bugs.eclipse.org/bugs/attachment.cgi?id=173662 commit in r2279.
Comment 10 Hubert Dubois CLA 2010-07-09 12:29:03 EDT
Created attachment 173880 [details]
Some addings

- Drag and Drop management
- Corrections in the Diagram Edit Part Policies
Comment 11 Hubert Dubois CLA 2010-07-09 12:29:13 EDT
- Drag and Drop management
- Corrections in the Diagram Edit Part Policies
Comment 12 Yann Tanguy CLA 2010-07-09 12:46:08 EDT
Patch https://bugs.eclipse.org/bugs/attachment.cgi?id=173880 commit in r2345.
Comment 13 Hubert Dubois CLA 2010-07-12 08:18:10 EDT
Created attachment 174016 [details]
Corrections

- Errors management
- Internationalization management corrections
- Constraints names
- Palette management
Comment 14 Hubert Dubois CLA 2010-07-12 08:18:18 EDT
- Errors management
- Internationalization management corrections
- Constraints names
- Palette management
Comment 15 Yann Tanguy CLA 2010-07-12 11:53:33 EDT
Patch https://bugs.eclipse.org/bugs/attachment.cgi?id=174016 commit in 2368.

Still to do:
- Log warning in ViewProviders "create" methods when no View could be created
- Modify InheritedElementEditPartProvider implementation : the provides method shall not use createEditPart method
- Bad default size for containment circle on creation

If containment link is used to decompose Requirement, is it normal to allow such "Decompose" link between packages ?
Comment 16 Hubert Dubois CLA 2010-07-13 10:02:27 EDT
Created attachment 174148 [details]
Bug corrections

- Log warning in viewProviders
- SysML Requirement diagram preferences editing view
Comment 17 Hubert Dubois CLA 2010-07-13 10:04:09 EDT
- Still some problems with modification of InheritedElementEditPart for avoiding tthe usage of createEdit Part. Problem with the Containment management; the line is completely unchanged.
Comment 18 Hubert Dubois CLA 2010-07-22 05:03:14 EDT
Created attachment 174946 [details]
Correction of inherited element edit part provider

- modification of the "provides" method: suppression of the "create" call

Still some problems with the view when Containement Link is selected: the view is empty ("null") instead of memorizing the selected elements.
Comment 19 Hubert Dubois CLA 2010-07-22 05:03:26 EDT
- modification of the "provides" method: suppression of the "create" call

Still some problems with the view when Containement Link is selected: the view is empty ("null") instead of memorizing the selected elements.
Comment 20 Hubert Dubois CLA 2010-07-23 08:54:08 EDT
Created attachment 175063 [details]
Corrections

-	logwarning from Requirement plugin
-	warning on build.properties
-	messages.properties corrections:
Comment 21 Hubert Dubois CLA 2010-07-23 08:54:16 EDT
-	logwarning from Requirement plugin
-	warning on build.properties
-	messages.properties corrections:
Comment 22 Yann Tanguy CLA 2010-07-23 10:02:08 EDT
Patch https://bugs.eclipse.org/bugs/attachment.cgi?id=175063 committed (with minor changes in r2463)
Comment 23 Yann Tanguy CLA 2010-08-18 14:14:41 EDT
Various fixes (r2522) :
- EditPart provider for inherited elements was incorrect
- View provider for inherited elements was incorrect or incomplete
- Several elements were incorrectly 
- Orphan edit policy added to Diagram edit part
- Inherited types incomplete (in plugin.xml, element type declaration and providers)
Comment 24 Vincent Lorenzo CLA 2010-09-17 03:21:22 EDT
In r2727 : 
	add the possibility to define the visibility of the compartments in the Papyrus Preferences Page (see bug 325419)
Comment 25 Hubert Dubois CLA 2010-10-01 10:45:08 EDT
Created attachment 180063 [details]
Corrections

Corrections :
- EditPart provider for inherited elements corrected
- View provider for inherited elements corrected and completed
- Inherited types incomplete in plugin.xml
Comment 26 Yann Tanguy CLA 2010-10-01 11:22:55 EDT
Could not test your patch, you are probably working on an old version of the source code :
- update your sources
- check if your changes are still relevant
- create a new patch

Thanks.
Comment 27 Hubert Dubois CLA 2010-10-13 11:39:58 EDT
Created attachment 180781 [details]
Corrections for Reqs Diagram

In these corrections :
- modification of SysML Requirement diagram preferences
- modification of Requirement elements aspects: icon and text associated to the stereotype
- profile stereotypes "text" and "id" are visible automatically when the element is created.
Comment 28 Hubert Dubois CLA 2010-10-13 11:44:49 EDT
Corrections for :
- requirement stereotype elements are visible: text and id
- icon and stereotype name are visible for the requirement element
- modification of SysML preferences
- addition of a postaction for icon visibility of requirement element in the palette
Comment 29 Yann Tanguy CLA 2010-11-04 11:08:23 EDT
In r3117: incorrect preference key corrected for ContainmentCircle
Comment 30 Yann Tanguy CLA 2010-11-04 11:49:02 EDT
In r3118: Minor changes in palette xml (tool ids and SysML icons)
Comment 31 Yann Tanguy CLA 2010-11-04 13:23:42 EDT
In r3120: 
- UML related compartment (Property, Operation, NestedClassifier) are not quite useful for Requirement and will be masked on creation.

ToDo: Provide Requirement related information, Id and Text directly on figure with editing capabilities.
Comment 32 Hubert Dubois CLA 2010-11-26 11:51:31 EST
Created attachment 183938 [details]
adding of comments and constraints elements.

adding of comments and constraints elements.
Comment 33 Hubert Dubois CLA 2010-11-26 11:51:51 EST
Comments and constraints elements.
Comment 34 Yann Tanguy CLA 2010-11-29 04:50:05 EST
(In reply to comment #32)
> Created an attachment (id=183938)
> adding of comments and constraints elements.
> 
> adding of comments and constraints elements.

Incorrect patch -> update your source code first.
Comment 35 Hubert Dubois CLA 2010-11-30 09:43:15 EST
Created attachment 184135 [details]
Management of Link for Comments, constraints and Trace Links

- Modifications in the palette for the Trace Link
- Adding of primitives for Comment, Constraints and Trace links
Comment 36 Yann Tanguy CLA 2010-11-30 13:52:50 EST
Too many issues remaining, don't expect the following patches to be committed:
- Created an attachment (id=183938)
- Created an attachment (id=184135)
Comment 37 Hubert Dubois CLA 2010-12-10 06:48:28 EST
Created attachment 184941 [details]
Corrections of errors

Correction of edition problems for requirements.
Requirements have now the same appearance when created, opened and moved.

Adding of Comments, constraints, Trace & Link links
Comment 38 Hubert Dubois CLA 2010-12-10 06:48:43 EST
Correction of edition problems for requirements.
Requirements have now the same appearance when created, opened and moved.

Adding of Comments, constraints, Trace & Link links
Comment 39 Patrick Tessier CLA 2011-05-23 12:00:12 EDT
Created attachment 196356 [details]
new requirement Plugin by using a generative approach
Comment 40 Patrick Tessier CLA 2011-05-23 12:01:57 EDT
Bec ause this is not a patch and the structure has totaly changed, the current plugin will be moved in the deprecated directory and the zip will replace it in the sysml directory
Comment 41 Patrick Tessier CLA 2011-05-23 12:09:08 EDT
the old requirement diagram has moved  in  http://dev.eclipse.org/svnroot/modeling/org.eclipse.mdt.papyrus/trunk/extraplugins/deprecated-plugins/sysml.deprecated  
done in the revision 4763
Comment 42 Patrick Tessier CLA 2011-05-23 13:32:02 EDT
The given plugin does not run, so I set the old plugin at he former place
Comment 43 Monica Hicks CLA 2011-09-28 04:02:18 EDT
Thank you very much !! You have shared very good information with us. I will also tell about it to my friends also in fact all the people known to me. <a href="http://www.pampersgiftstogrowcodes.com/">Pampers Gifts To Grow Codes</a>(In reply to comment #1)
Comment 44 Camille Letavernier CLA 2014-03-25 15:25:08 EDT
I close this task