Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315762

Summary: bundles with compile errors never published even through p2.publishonerror is set to "true"
Product: [Eclipse Project] PDE Reporter: Kirill A. Balod <Kirill.Balod>
Component: BuildAssignee: pde-build-inbox <pde-build-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: aniefer, darin.eclipse
Version: 4.0Flags: darin.eclipse: review+
Target Milestone: 3.6.1   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 316641    
Attachments:
Description Flags
patch aniefer: iplog+

Description Kirill A. Balod CLA 2010-06-04 09:42:33 EDT
Build Identifier: 3.6RC2

org.eclipse.pde.internal.build.builder.ModelBuildScriptGenerator has an mistake and as result generated build.xml contains condition:
        <property name="compilation.problem.marker" value="${build.result.folder}/compilation.problem"/>
        <condition property="compilation.problem.marker.exists" value="true"        >
            <and>
            <available file="${compilation.problem.marker}"/>
            <isfalse value="p2.publishonerror"/>
            </and>
        </condition>
where: 
<isfalse value="p2.publishonerror"/>
because "isfalse - Tests whether a string is not true, the negation of <istrue>" (c) Ant Manual - this condition always true independently of "p2.publishonerror" property
It should be:
<isfalse value="${p2.publishonerror}"/>

It is result of fix of bug [269972]
https://bugs.eclipse.org/bugs/show_bug.cgi?id=269972
	





Reproducible: Always
Comment 1 Kirill A. Balod CLA 2010-06-04 09:44:31 EDT
Created attachment 171099 [details]
patch

small, easy, safe path
Comment 2 Andrew Niefer CLA 2010-06-11 14:21:07 EDT
bug 316641 fixed this in HEAD for 3.7.  3.6.1 development stream has not started yet.
Comment 3 Andrew Niefer CLA 2010-07-06 14:24:59 EDT
done in 3.6.1