Bugzilla – Full Text Bug Listing
| Summary: | Enable autolaunch of pbs proxy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Greg Watson <g.watson> | ||||
| Component: | RM.PBS | Assignee: | Greg Watson <g.watson> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | arossi, roland | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 4.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Greg Watson
Created attachment 171061 [details]
autolaunch patch
Great. Works. Only problem was that the build.sh was missing org.eclipse.ptp.utils.core. The proxy depends on that package too. That's why the nodes didn't show up. Please go ahead and commit it. I'm happy to commit it but I'm not sure what remains to be done for build.xml and without being able to test it - it would be great if you can do that. Al: Please commit the UI change we discussed. Let me know if you have something I can help. Until I hear something from you I'll work on some of the other bugs. I've committed the UI changes. great. Looks good. I guess in most cases it won't work with RSE because of missing port forwarding. Yesterday I got this forwarding issue confused with this unrelated autolaunch issue. That is why I was confused that it would also work with RSE. Committed. I'll work on the build script and see if I can get it into tonight's build. It should still work with RSE, but you won't be able to forward over an ssh connection. If your local machine accepts incoming connections it should be fine. Roland, can you set your formatting to use a column width of 132? It'll make merging easier. Thanks. OK. Great. Changed it to 132. Could you (after the release) export your Code-Style->Formatter settings and put them on the wiki. That would make it easier. There is one more problem: createExecutionManager called by: org.eclipse.ptp.remote.remotetools.core.environment.PTPTargetControl.createExecutionManager() org.eclipse.ptp.remote.remotetools.core.RemoteToolsConnection.createExecutionManager() org.eclipse.ptp.remote.remotetools.core.RemoteToolsProcessBuilder.start() org.eclipse.ptp.remote.launch.core.AbstractRemoteServerRunner.launchServer(IRemoteConnection, IProgressMonitor) checks that the connection is connected correctly but does not automatically reconnect if it is not connected anymore. Thus when one tries to start a RM and the connection is not open anymore one gets: "Connection is not open" as an error. Is it OK to change createExecutionManager to automatically reconnect? Or on what level of the above call-tree should the reconnect be implemented to not break anything else? AbstractRemoteServerRunner.startServer already checks if the connection is open and reopens it if not. Is this not working? In any case, Remote Tools should not automatically reopen connections. This should be left as the callers responsibility. (In reply to comment #7) > AbstractRemoteServerRunner.startServer already checks if the connection is open > and reopens it if not. Is this not working? > > In any case, Remote Tools should not automatically reopen connections. This > should be left as the callers responsibility. yes startServer does. But launchServer didn't. I just committed a change that launchServer does the same as startServer. This is not correct. launchserver is only called by the job run method after startserver is called. it shouldn't need to reopen the connection since startserver already checks this. I've reversed this commit. (In reply to comment #10) > I've reversed this commit. Sorry. Yes that change didn't make any sense. I opened a new bug (315864) for the connection reopen problem. When I try to launch a local version of the proxy, I get Unable to locate payload "pbs_proxy.jar" in bundle "org.eclipse.ptp.rm.pbs.jproxy" And, indeed, I don't see any .jar in the plugin. I've sync'd with CVS Head. What am I doing wrong? you need to run the build.sh script |