Bugzilla – Full Text Bug Listing
| Summary: | unwrap connection should never begin transaction | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Andrei Ilitchev <andrei.ilitchev> |
| Component: | Eclipselink | Assignee: | Nobody - feel free to take it <nobody> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
Thirdly, currently even if unitOfWork is already in transaction then no connection returned. Here's a cleaned up version of the suggested patch:
} else if (cls.equals(java.sql.Connection.class)) {
UnitOfWorkImpl unitOfWork = (UnitOfWorkImpl) this.getUnitOfWork();
if(unitOfWork.isInTransaction() || unitOfWork.getParent().isExclusiveIsolatedClientSession()) {
return (T) unitOfWork.getAccessor().getConnection();
}
if (checkForTransaction(false) != null) {
unitOfWork.beginEarlyTransaction();
return (T) unitOfWork.getAccessor().getConnection();
}
return null;
}
Fixed in trunk. The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink |
EntityManagerImpl.unwrap method may begin transaction to unwrap connection: } else if (cls.equals(java.sql.Connection.class)) { UnitOfWorkImpl unitOfWork = (UnitOfWorkImpl) this.getUnitOfWork(); if (!unitOfWork.isInTransaction()) { unitOfWork.beginEarlyTransaction(); return (T) unitOfWork.getAccessor().getConnection(); } } First of all, if uow's parent is ExclusiveIsolatedClientSession then the connection is alwaya available - no need to beginEarlyTransaction; Secondly - and most important - in JTA environment with no transaction it will start a JTA transaction. It should be called only inside transaction. I suggest something like: } else if (cls.equals(java.sql.Connection.class)) { UnitOfWorkImpl unitOfWork = (UnitOfWorkImpl) this.getUnitOfWork(); if(unitOfWork.getParent().isExclusiveIsolatedClientSession() { return (T) unitOfWork.getAccessor().getConnection(); } if (checkForTransaction(false) != null && !unitOfWork.isInTransaction()) { unitOfWork.beginEarlyTransaction(); } if(unitOfWork.isInTransaction()) { return (T) unitOfWork.getAccessor().getConnection(); } else { return null; } }