Bugzilla – Full Text Bug Listing
| Summary: | ClassCastException: EvaluationException cannot be cast to org.eclipse.emf.ecore.EObject | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] TMF | Reporter: | Rubén Porras Campo <Ruben.PorrasCampo> | ||||||
| Component: | Xtext | Assignee: | Jan Koehnlein <jan> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | major | ||||||||
| Priority: | P3 | CC: | Holger.Schill, jan, sebastian.zarnekow, sven.efftinge, tmf.xtext-inbox | ||||||
| Version: | 1.0.0 | Flags: | jan:
helios+
|
||||||
| Target Milestone: | SR1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Rubén Porras Campo
No information about why a Validator failed, renders the validator almost unusable. Hence upgrading the importance to major. I can only reproduce the problem if the fragment validation.CheckFragment is in use. The JavaValidatorFragment does not seem to trigger the problem. Created attachment 171253 [details]
Patch for IssueImpl
It looks like we call IssueImpl.addError(String, Object) with an exception as second argument, thus interpreting the exception as an erroneous object. This will make the Adapter throw the class cast exception.
Please try the attached patch. If the error persists, we need more information, e.g. your check file and an example model.
Committers: Please review the attached patch.
I will test it as soon as the RC4 if availabre at the OAW working group webpage. Currently it is only a patch, so not yet committed to source. If you rely on this to be fixed, I asked you to check if the patch fixes your error. Without your cooperation it's unlikely this patch makes it into the release, as we are in the late RCs thus only urgent changes will make it. In your case testing should be easy: Import-> Plugins & Fragments -> org.eclipse.emf.mwe.core Apply the patch (Team -> Apply patch) and re-run the workflow. Hi Jan, I would had done it if had known how. Thanks for the mini-tutorial. The problem is, that the org.eclipse.emf.mwe.core provided by the OAW working group download has no source. I also tried downloading eclipse from http://www.eclipse.org/downloads/index-helios.php and installing the mwe framework with the update manager. Also no source folder. How can I get the source code for org.eclipse.emf.mwe.core? Hi Ruben, in the import-wizard you could define if you want the sourcecode. Please have a look at the section "import as" in the wizard. The standard selections says binaries only. Regards, Holger The patch is NOT OK, The stack trace is still the same. The call goes to
public void addError(final String msg, final Object element) {
addError(null, msg, element, null, Collections.emptyList());
}
instead to the patched methode.
Created attachment 171400 [details]
Patch resolving the Issue
I have attached a new patch that solves the issue After applying the patch there is a new Issue. Should I report a new issue or would you like to look at it in this bug? The new StackTrace is java.lang.RuntimeException: Problems running workflow workflow.btt.fidd: null at org.eclipse.emf.mwe2.launch.runtime.Mwe2Runner.run(Mwe2Runner.java:82) at org.eclipse.emf.mwe2.launch.runtime.Mwe2Runner.run(Mwe2Runner.java:52) at org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.run(Mwe2Launcher.java:74) at org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main(Mwe2Launcher.java:35) Caused by: java.lang.NullPointerException at org.eclipse.xtext.mwe.Validator$2.apply(Validator.java:164) at org.eclipse.xtext.mwe.Validator$2.apply(Validator.java:1) at com.google.common.collect.Multimaps.index(Multimaps.java:1396) at org.eclipse.xtext.mwe.Validator.groupByURI(Validator.java:161) at org.eclipse.xtext.mwe.Validator.appendMessages(Validator.java:120) at org.eclipse.xtext.mwe.Validator.toString(Validator.java:103) at org.eclipse.xtext.mwe.Validator.validate(Validator.java:87) at org.eclipse.xtext.mwe.Reader.invokeInternal(Reader.java:165) at org.eclipse.emf.mwe.core.lib.AbstractWorkflowComponent.invoke(AbstractWorkflowComponent.java:126) at org.eclipse.emf.mwe.core.lib.Mwe2Bridge.invoke(Mwe2Bridge.java:34) at org.eclipse.emf.mwe.core.lib.AbstractWorkflowComponent.invoke(AbstractWorkflowComponent.java:201) at org.eclipse.emf.mwe2.runtime.workflow.AbstractCompositeWorkflowComponent.invoke(AbstractCompositeWorkflowComponent.java:31) at org.eclipse.emf.mwe2.runtime.workflow.Workflow.run(Workflow.java:19) at org.eclipse.emf.mwe2.launch.runtime.Mwe2Runner.run(Mwe2Runner.java:80) ... 3 more Marking this one as New as nobody seems to work on it actively. Sorry your patch did not make it into 1.0. I've fixed the issue in two places: - o.e.xtend.internal.ast.Ckeck now calls the correct Issues.addIssue() method - o.e.xtext.xtend.AbstractCheckValidator checks the issue's element for being an EObject If the second problem persists, please open a new bug. Closing all bugs that were set to RESOLVED before Neon.0 Closing all bugs that were set to RESOLVED before Neon.0 |