Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315529

Summary:

Backport [terminal] Terminal always jumps to line 1 if ScrollLock is activated

Product:

[Tools] Target Management

Reporter:

Martin Oberhuber <mober.at+eclipse>

Component:

Terminal

Assignee:

Martin Oberhuber <mober.at+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

creynaud, eclipse, uwe.st, wb-rel

Version:

3.1.1

Flags:

uwe.st: review+

Target Milestone:

3.1.2+

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

205486, 294468

Bug Blocks:

Attachments:

Description	Flags
Patch including all changes and version updates	none

Description Martin Oberhuber

2010-06-03 00:05:52 EDT

+++ This bug was initially created as a clone of Bug #205486 +++

In our commercial product on top of Eclipse, we have activated the TerminalActionScrollLock in a custom view embedding the Terminal widget. Unfortunately, it turns out that the Terminal always jumps to line 1 of the output when scroll lock is chosen.

The patch in attachment 170909 [details] on bug 205486 resolves that issue.

Comment 1 Martin Oberhuber

2010-06-03 00:30:58 EDT

It turns out that it's impossible to backport the fix for bug 205486 without also backporting the fix for bug 294468. Essentially, we synchronize the 3.1.2+ Terminal widget with the 3.2 version.

Comment 2 Martin Oberhuber

2010-06-03 00:34:01 EDT

Created attachment 170910 [details]
Patch including all changes and version updates

Attached patch includes all changes and version updates. Unfortunately, due to the feature inclusion structure, features upto rse.sdk are affected.

Affected plugins:
-----------------
org.eclipse.tm.terminal

Affected features:
------------------
org.eclipse.tm.terminal
org.eclipse.tm.terminal.sdk
org.eclipse.rse.terminals
org.eclipse.rse
org.eclipse.rse.sdk

Comment 3 Martin Oberhuber

2010-06-03 00:35:14 EDT

Hi Uwe, our policy has it that backports for a maintenance stream require a single additional committer's review. Please give you review+ so I can proceed checking in the changes and having a J-build created.

Comment 4 Martin Oberhuber

2010-06-03 04:47:48 EDT

Released, please verify with J20100603-0600 (will be available around 1300 CEST)