Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315512

Summary: Error opening "New Report..." wizard (Right-click monitor > New Report...)
Product: z_Archived Reporter: Mike Reid <mikereid>
Component: TPTPAssignee: Mike Reid <mikereid>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: major    
Priority: P2 CC: ernest, jcayne, jgwest
Version: unspecifiedFlags: jgwest: pmc_approved? (oec)
ernest: pmc_approved+
jgwest: pmc_approved? (kathy)
jgwest: pmc_approved? (paulslau)
jgwest: pmc_approved? (jgwest)
jcayne: review+
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Screenshot showing the error
none
Workspace .log
none
Switch backslashes to forward slashes in plugin.xml none

Description Mike Reid CLA 2010-06-02 18:27:04 EDT 
Build Identifier: TPTP-4.7.0-201006011014

With TPTP-4.7.0-201006011014



Reproducible: Always

Steps to Reproduce:
1. Profile an application
2. Right-click a node in the "Profiling Monitor" view and select "New report..."

The New Report wizard starts, but an error dialog also pops up under it. Screenshot attached.
Comment 1 Mike Reid CLA 2010-06-02 18:28:14 EDT 
Created attachment 170891 [details]
Screenshot showing the error
Comment 2 Mike Reid CLA 2010-06-02 18:29:12 EDT 
Created attachment 170892 [details]
Workspace .log
Comment 3 Kathy Chan CLA 2010-06-03 15:13:18 EDT 
Mike,

Is this a regression?  It looks like it might be a problem with one of the TPTP prereq.  Please try to isolate the problem a bit further.  Thanks!
Comment 4 Mike Reid CLA 2010-06-03 16:10:35 EDT 
Created attachment 171017 [details]
Switch backslashes to forward slashes in plugin.xml

Seems that some underlying Eclipse API now no longer likes backslashes in URLs. Patch attached which specifies the path to the icon with forward slashes.
Comment 5 Mike Reid CLA 2010-06-03 16:24:53 EDT 
Patch confirmed on Linux and Windows.

Joel can you please review this?
Comment 6 Joel Cayne CLA 2010-06-03 16:54:39 EDT 
Patch looks good.

Please update the Copyright in the header. After searching, there do not appear to be other plug-ins using the extension point with backslashes in the URL.
Comment 7 Kathy Chan CLA 2010-06-04 07:25:54 EDT 
+1 for getting this in TPTP 4.7.  

Mike, please fill in the PMC template and ask Jonathan to bring this forward.  Thanks!
Comment 8 Mike Reid CLA 2010-06-04 08:34:06 EDT 
Jonathan, please bring this forward for PMC review:

   1.   Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?

Error message when opening "New Report..." wizard. 

   2. Is there a work-around? If so, why do you believe the work-around is insufficient?

No workaround to prevent the error; dialog must be dismissed.

   3. Is this a regression or API breakage? Explain.

Regression; no API breakage.

   4. Does this require new API?

No

   5. Who performed the code review?

Joel Cayne

   6. Is there a test case attached to the bugzilla record?
No

   7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix?

The fix is a trivial, non-code fix. Scope limited to the "New Report..." wizard; risk is low.

   8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?

No.
Comment 9 Jonathan West CLA 2010-06-04 10:31:52 EDT 
Hi folks, requesting PMC approval for TPTP 4.7.
Comment 10 Jonathan West CLA 2010-06-04 11:13:23 EDT 
Patch checked into HEAD w/ PMC approval.
Comment 11 Mike Reid CLA 2010-07-13 11:09:46 EDT 
Verified fix in 4.7 release.
Comment 12 Kathy Chan CLA 2010-11-18 23:29:44 EST 
Closing.