Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315468

Summary: [UI] Using the MContribution's 'persistedState' field causes a CCE when trying to publish the event
Product: [Eclipse Project] e4 Reporter: Eric Moffatt <emoffatt>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED FIXED QA Contact: Eric Moffatt <emoffatt>
Severity: normal    
Priority: P3 CC: remy.suen
Version: unspecified   
Target Milestone: 1.0 RC0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch to wire off publishing events that weren't generated from an MApplicationElement none

Description Eric Moffatt CLA 2010-06-02 15:38:13 EDT 
The code in UIEventPublisher expects to be publishing events for MApplicationElements but the 'persistedState' field is defined as an EMF type that is not (the cause of the CCE).

As an interim fix I'll only attempt to publish UI events for MApplicationElements. The only downside to this would be if someone needed to listen to changes in that field; extremely unlikely IMO...the person *setting* the field shouldn't need to listen and why the heck would (or even should) anyone else be trying to listen in?
Comment 1 Eric Moffatt CLA 2010-06-02 15:39:32 EDT 
Created attachment 170869 [details]
Patch to wire off publishing events that weren't generated from an MApplicationElement
Comment 2 Eric Moffatt CLA 2010-06-02 15:40:53 EDT 
Committed in >20100602. Applied the patch.
Comment 3 Brian de Alwis CLA 2010-06-02 17:40:17 EDT 
I no longer get CCEs, and the values are persisted out into the deltas.xml.  But the persisted values don't seem to be loaded on restart.
Comment 4 Eric Moffatt CLA 2010-06-03 16:18:25 EDT 
Remy, could you take a look to see whether this is a reconciler issue?
Comment 5 Remy Suen CLA 2010-06-03 19:21:48 EDT 
(In reply to comment #3)
> I no longer get CCEs, and the values are persisted out into the deltas.xml. 
> But the persisted values don't seem to be loaded on restart.

This should be fixed by bug 315698.
Comment 6 Eric Moffatt CLA 2010-06-21 13:01:41 EDT 
Marking as FIXED. Brian, please re-open this if it's not working for you in today's build (I20100618-1748).