Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315435

Summary:

Fix the regression test failures in cdt70(comparing with cdt50)

Product:

[Tools] CDT

Reporter:

John Liu <john_ws_liu>

Component:

cdt-parser

Assignee:

Vivian Kong <vivkong>

Status:

RESOLVED FIXED

QA Contact:

Mike Kucera <mikekucera>

Severity:

normal

Priority:

CC:

vivkong

Version:

7.0

Target Milestone:

7.0

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch to org.eclipse.cdt.core, org.eclipse.cdt.core.test, org.eclipse.cdt.core.lrparser, org.eclipse.cdt.core.lrparser.test, org.eclipse.cdt.core.lrparser.xlc, org.eclipse.cdt.core.lrparser.xlc.test	none
Fix patch with updated copyright statement	vivkong: iplog+
Patch to overwrite some cdt core test cases, apply to lr.parser.xlc.test	vivkong: iplog+
upc parser applied to parser.upc	vivkong: iplog+
test overwrite patch apply to 3 test plugins..	vivkong: iplog+

Description John Liu

2010-06-02 13:43:20 EDT

Build Identifier: cdt70

There are 96 (8 errors) test faliures in xlc parser when we just port cdt 70.

Among them, some test cases which were passed in cdt 50 are failed by cdt 70 due to some parser api change, ast structure change etc..

This bug is to address these failures:

AST2CPPTests:

testBug89539

DOMLocationTests:

testBaseCase				FIX
testSimpleDeclaration

AST2Tests:


testDesignatedInitializers E		
testMoregetDeclarationsInAST1 E				 testMoregetDeclarationsInAST2 E				 testMoregetDeclarationsInAST3 E	

AST2UtilOldTests:

testPostfixSimpletypesBug42823		FIX

Reproducible: Always

Comment 1 John Liu

2010-06-02 14:52:37 EDT

Created attachment 170860 [details]
patch to org.eclipse.cdt.core, org.eclipse.cdt.core.test, org.eclipse.cdt.core.lrparser, org.eclipse.cdt.core.lrparser.test, org.eclipse.cdt.core.lrparser.xlc, org.eclipse.cdt.core.lrparser.xlc.test

patch to org.eclipse.cdt.core, org.eclipse.cdt.core.test, org.eclipse.cdt.core.lrparser, org.eclipse.cdt.core.lrparser.test, org.eclipse.cdt.core.lrparser.xlc, org.eclipse.cdt.core.lrparser.xlc.test

Comment 2 John Liu

2010-06-02 14:54:25 EDT

The patch fixed these:

1, fix parserHelper to adpat new parser api, using file content.

* test case, testPostfixSimpletypesBug42823

2 ( //CDT_70_FIX_FROM_50-#2)

 IASTInitializerExpression is depreciated and replaced by IASTEqualsInitializer.

This will update 
	* BuildASTParserAction at function consumeInitializer, 
	* CPPBuildASTParserAction class at function consumeConditionDeclaration and function 		
	  consumeMemberDeclaratorWithInitializer.
      * LRDigraphTrigraphTests at function testTrigraphAndDigraphSequecesInPreprocessorDirectives


3(//CDT_70_FIX_FROM_50-#3) 

nodeFactory.newSimpleTypeConstructorExpression(int type, IASTExpression expression); is depreciated and replaced by nodeFactory.newSimpleTypeConstructorExpression(ICPPASTDeclSpecifier declSpec, IASTInitializer initializer)

Update class CPPBuildASTParserAction at function consumeExpressionSimpleTypeConstructor and add a new function 
transformIntoSimpleTypeSpecifier(IToken token)

4, bugzilla 302412 syntax for initializer lists (//CDT_70_FIX_FROM_50-#4) 

4.1 update grammer by adding consumeInitializer() to the 2nd rule.

initializer_clause
    ::= assignment_expression
         /. $Build  consumeInitializer();  $EndBuild ./
      | initializer_list
         /. $Build  consumeInitializer();  $EndBuild ./

4.2 update BuildASTParserAction at function consumeInitializer 

5 CPPASTConstructorInitializer.setExpression is depreciated.(CDT_70_FIX_FROM_50-#5)

update CPPBuildASTParserAction  at function consumeInitializerConstructor()

6 fix testBug89539 (CDT_70_FIX_FROM_50-#6)
update CPPASTConstructorChainInitializer.setInitializerValue()

7, IGPPASTSimpleDeclSpecifier is depreciated and replaced by ICPPASTSimpleDeclSpecifier (CDT_70_FIX_FROM_50-#7)

fix GPPBuildASTParserAction.consumeDeclarationSpecifiersTypeof and GPPBuildASTParserAction.consumeDeclarationSpecifiersSimple

8 fix testLiteralsViaOverloads_225534, (CDT_70_FIX_FROM_50-#8)

if a ICPPASTDeclSpecifier has been set as long, do not set it as long, fix CPPBuildASTParserAction.setSpecifier(ICPPASTDeclSpecifier node, Object specifier)

9 update static_assert test case, (CDT_70_FIX_FROM_50-#9)

override test function XlcLRCPPTests.testStaticAssertions_294730()
remove XlcExtensionsTest.testStaticAssertions()

10, Test cases typos:

// class Other {
	//    void m(); };
	// class A {                       
	//    friend void set();           
	//    friend void Other::m();             
	// };                              
AST2CPPTests	public void testFriend_Bug275358() throws Exception {

Comment 3 John Liu

2010-06-02 15:06:35 EDT

Created attachment 170863 [details]
Fix patch with updated copyright statement

patch to org.eclipse.cdt.core, org.eclipse.cdt.core.test,
org.eclipse.cdt.core.lrparser, org.eclipse.cdt.core.lrparser.test,
org.eclipse.cdt.core.lrparser.xlc, org.eclipse.cdt.core.lrparser.xlc.test

patch to org.eclipse.cdt.core, org.eclipse.cdt.core.test,
org.eclipse.cdt.core.lrparser, org.eclipse.cdt.core.lrparser.test,
org.eclipse.cdt.core.lrparser.xlc, org.eclipse.cdt.core.lrparser.xlc.test
updated copyright statement

Comment 4 Vivian Kong

2010-06-02 15:36:18 EDT

Applied to HEAD (except the ones in cdt.core and cdt.core.tests)

Comment 5 CDT Genie

2010-06-02 16:23:20 EDT

*** cdt cvs genie on behalf of vkong ***
Bug 315435 Fix the regression test failures in cdt70

[*] XlcLRCPPTests.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCPPTests.java?root=Tools_Project&r1=1.1&r2=1.2

[*] XlcExtensionsTest.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/XlcExtensionsTest.java?root=Tools_Project&r1=1.2&r2=1.3

[*] GPPParser.java 1.20 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/gpp/GPPParser.java?root=Tools_Project&r1=1.19&r2=1.20
[*] GPPSizeofExpressionParser.java 1.16 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/gpp/GPPSizeofExpressionParser.java?root=Tools_Project&r1=1.15&r2=1.16

[*] GCCSizeofExpressionParser.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/gcc/GCCSizeofExpressionParser.java?root=Tools_Project&r1=1.14&r2=1.15
[*] GCCParser.java 1.19 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/gcc/GCCParser.java?root=Tools_Project&r1=1.18&r2=1.19

[*] CPPNoCastExpressionParser.java 1.43 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/cpp/CPPNoCastExpressionParser.java?root=Tools_Project&r1=1.42&r2=1.43
[*] CPPExpressionParser.java 1.20 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/cpp/CPPExpressionParser.java?root=Tools_Project&r1=1.19&r2=1.20
[*] CPPNoFunctionDeclaratorParser.java 1.32 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/cpp/CPPNoFunctionDeclaratorParser.java?root=Tools_Project&r1=1.31&r2=1.32
[*] CPPSizeofExpressionParser.java 1.40 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/cpp/CPPSizeofExpressionParser.java?root=Tools_Project&r1=1.39&r2=1.40
[*] CPPTemplateTypeParameterParser.java 1.23 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/cpp/CPPTemplateTypeParameterParser.java?root=Tools_Project&r1=1.22&r2=1.23
[*] CPPParser.java 1.53 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/cpp/CPPParser.java?root=Tools_Project&r1=1.52&r2=1.53

[*] C99Grammar.g 1.21 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/grammar/c99/C99Grammar.g?root=Tools_Project&r1=1.20&r2=1.21

[*] CPPGrammar.g 1.47 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/grammar/cpp/CPPGrammar.g?root=Tools_Project&r1=1.46&r2=1.47

[*] BuildASTParserAction.java 1.52 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/core/dom/lrparser/action/BuildASTParserAction.java?root=Tools_Project&r1=1.51&r2=1.52

[*] CPPBuildASTParserAction.java 1.65 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/core/dom/lrparser/action/cpp/CPPBuildASTParserAction.java?root=Tools_Project&r1=1.64&r2=1.65

[*] GPPBuildASTParserAction.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/core/dom/lrparser/action/gnu/GPPBuildASTParserAction.java?root=Tools_Project&r1=1.7&r2=1.8

[*] C99ExpressionParser.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/c99/C99ExpressionParser.java?root=Tools_Project&r1=1.16&r2=1.17
[*] C99SizeofExpressionParser.java 1.23 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/c99/C99SizeofExpressionParser.java?root=Tools_Project&r1=1.22&r2=1.23
[*] C99Parser.java 1.28 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/c99/C99Parser.java?root=Tools_Project&r1=1.27&r2=1.28
[*] C99NoCastExpressionParser.java 1.24 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser/src/org/eclipse/cdt/internal/core/dom/lrparser/c99/C99NoCastExpressionParser.java?root=Tools_Project&r1=1.23&r2=1.24

[*] LRDigraphTrigraphTests.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRDigraphTrigraphTests.java?root=Tools_Project&r1=1.7&r2=1.8
[*] ParseHelper.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/ParseHelper.java?root=Tools_Project&r1=1.7&r2=1.8

[*] XlcCParser.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc/parser/org/eclipse/cdt/internal/core/lrparser/xlc/c/XlcCParser.java?root=Tools_Project&r1=1.4&r2=1.5

[*] XlcCPPParser.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc/parser/org/eclipse/cdt/internal/core/lrparser/xlc/cpp/XlcCPPParser.java?root=Tools_Project&r1=1.7&r2=1.8

Comment 6 CDT Genie

2010-06-03 10:23:02 EDT

*** cdt cvs genie on behalf of vkong ***
Bug 315435 Fix the regression test failures in cdt70

[*] AST2BaseTest.java 1.75 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2BaseTest.java?root=Tools_Project&r1=1.74&r2=1.75

Comment 7 John Liu

2010-06-03 11:38:06 EDT

Created attachment 170970 [details]
Patch to overwrite some cdt core test cases, apply to lr.parser.xlc.test

Comment 8 CDT Genie

2010-06-03 14:23:38 EDT

*** cdt cvs genie on behalf of vkong ***
Bug 315435 Fix the regression test failures in cdt70

[*] XlcLRCPPImplicitNameTests.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCPPImplicitNameTests.java?root=Tools_Project&r1=1.1&r2=1.2
[*] XlcLRTests.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRTests.java?root=Tools_Project&r1=1.1&r2=1.2
[*] XlcLRDOMLocationTests.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRDOMLocationTests.java?root=Tools_Project&r1=1.1&r2=1.2
[*] XlcLRTemplateTests.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRTemplateTests.java?root=Tools_Project&r1=1.1&r2=1.2
[*] XlcLRCPPSpecTest.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCPPSpecTest.java?root=Tools_Project&r1=1.1&r2=1.2
[*] XlcCompletionHangingTest.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcCompletionHangingTest.java?root=Tools_Project&r1=1.2&r2=1.3
[*] XlcLRCPPTests.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCPPTests.java?root=Tools_Project&r1=1.2&r2=1.3
[*] XlcLRCompletionBasicTest.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCompletionBasicTest.java?root=Tools_Project&r1=1.1&r2=1.2

Comment 9 John Liu

2010-06-03 15:24:13 EDT

Created attachment 171006 [details]
upc parser applied to parser.upc

Comment 10 John Liu

2010-06-03 15:25:51 EDT

Created attachment 171007 [details]
test overwrite patch apply to 3 test plugins..

Comment 11 Vivian Kong

2010-06-03 16:01:05 EDT

I've back out changes from comment 7 and checked in your latest patches (comment 9 and comment 10).  I added the @Override tags to avoid compiler warnings.

Comment 12 CDT Genie

2010-06-03 16:23:18 EDT

*** cdt cvs genie on behalf of vkong ***
Bug 315435 Fix the regression test failures in cdt70 - for John Liu

[*] UPCExpressionParser.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/upc/org.eclipse.cdt.core.parser.upc/src/org/eclipse/cdt/internal/core/dom/parser/upc/UPCExpressionParser.java?root=Tools_Project&r1=1.13&r2=1.14
[*] UPCSizeofExpressionParser.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/upc/org.eclipse.cdt.core.parser.upc/src/org/eclipse/cdt/internal/core/dom/parser/upc/UPCSizeofExpressionParser.java?root=Tools_Project&r1=1.14&r2=1.15
[*] UPCParser.java 1.27 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/upc/org.eclipse.cdt.core.parser.upc/src/org/eclipse/cdt/internal/core/dom/parser/upc/UPCParser.java?root=Tools_Project&r1=1.26&r2=1.27
[*] UPCNoCastExpressionParser.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/upc/org.eclipse.cdt.core.parser.upc/src/org/eclipse/cdt/internal/core/dom/parser/upc/UPCNoCastExpressionParser.java?root=Tools_Project&r1=1.14&r2=1.15

[*] XlcLRCPPImplicitNameTests.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCPPImplicitNameTests.java?root=Tools_Project&r1=1.2&r2=1.3
[*] XlcLRTests.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRTests.java?root=Tools_Project&r1=1.2&r2=1.3
[*] XlcLRDOMLocationTests.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRDOMLocationTests.java?root=Tools_Project&r1=1.2&r2=1.3
[*] XlcLRTemplateTests.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRTemplateTests.java?root=Tools_Project&r1=1.2&r2=1.3
[*] XlcLRCPPSpecTest.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCPPSpecTest.java?root=Tools_Project&r1=1.2&r2=1.3
[*] XlcLRCPPTests.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCPPTests.java?root=Tools_Project&r1=1.3&r2=1.4
[*] XlcLRCompletionBasicTest.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/xlc/org.eclipse.cdt.core.lrparser.xlc.tests/src/org/eclipse/cdt/core/parser/xlc/tests/base/XlcLRCompletionBasicTest.java?root=Tools_Project&r1=1.2&r2=1.3

[*] UPCTests.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/upc/org.eclipse.cdt.core.parser.upc.tests/src/org/eclipse/cdt/core/parser/upc/tests/UPCTests.java?root=Tools_Project&r1=1.3&r2=1.4
[*] UPCCompleteParser2Tests.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/upc/org.eclipse.cdt.core.parser.upc.tests/src/org/eclipse/cdt/core/parser/upc/tests/UPCCompleteParser2Tests.java?root=Tools_Project&r1=1.3&r2=1.4
[*] UPCDOMLocationMacroTests.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/upc/org.eclipse.cdt.core.parser.upc.tests/src/org/eclipse/cdt/core/parser/upc/tests/UPCDOMLocationMacroTests.java?root=Tools_Project&r1=1.3&r2=1.4

[*] LRTests.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRTests.java?root=Tools_Project&r1=1.14&r2=1.15
[*] LRTemplateTests.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRTemplateTests.java?root=Tools_Project&r1=1.6&r2=1.7
[*] LRCPPImplicitNameTests.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRCPPImplicitNameTests.java?root=Tools_Project&r1=1.1&r2=1.2
[*] AbstractLRHangingTest.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/AbstractLRHangingTest.java?root=Tools_Project&r1=1.2&r2=1.3
[*] LRCPPTests.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRCPPTests.java?root=Tools_Project&r1=1.10&r2=1.11
[*] LRCompletionBasicTest.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRCompletionBasicTest.java?root=Tools_Project&r1=1.6&r2=1.7
[*] LRDOMLocationTests.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRDOMLocationTests.java?root=Tools_Project&r1=1.8&r2=1.9
[*] LRCPPSpecTest.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/lrparser/org.eclipse.cdt.core.lrparser.tests/src/org/eclipse/cdt/core/lrparser/tests/LRCPPSpecTest.java?root=Tools_Project&r1=1.10&r2=1.11

Comment 13 Vivian Kong

2010-06-03 16:37:39 EDT

Everything should in HEAD now.  Thanks John!

Comment 14 CDT Genie

2010-06-03 17:38:05 EDT

*** cdt cvs genie on behalf of vkong ***
Bug 315435 Fix the regression test failures in cdt70 for John Liu

[*] CPPASTConstructorChainInitializer.java 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/CPPASTConstructorChainInitializer.java?root=Tools_Project&r1=1.17&r2=1.18

[*] AST2CPPTests.java 1.345 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2CPPTests.java?root=Tools_Project&r1=1.344&r2=1.345

[*] feature.xml 1.36 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.testing-feature/feature.xml?root=Tools_Project&r1=1.35&r2=1.36

[*] test.xml 1.27 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.testing/test.xml?root=Tools_Project&r1=1.26&r2=1.27

[*] cdt.map 1.90 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.releng/maps/cdt.map?root=Tools_Project&r1=1.89&r2=1.90

[*] test.xml 1.28 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.testing/test.xml?root=Tools_Project&r1=1.27&r2=1.28

Comment 15 Markus Schorn

2010-06-08 07:22:36 EDT

The change to CPPASTConstructorInitializer is not correct. Consider the following example:

   struct S {
      int a;
      S();
   };
   S::S() : a() {}

Here the mem-initializer contains a name and a ctor-style initializer. The correct AST is: 
   ICPPASTConstructorInitializer
      IASTName
      ICPPASTConstructorInitializer

With your change the generated AST is incomplete:
   ICPPASTConstructorInitializer
      IASTName


Note, with c++0x you could also have an initializer list:
   S::S() : a {}

The AST for that would be 
   ICPPASTConstructorInitializer
      IASTName
      ICPPASTInitializerList

Comment 16 Markus Schorn

2010-06-08 07:28:02 EDT

(In reply to comment #15)
Never mind, I mixed up the versions in the diff view. Your patch fixes exactly the problem I described. Thanks.

It'd be good to remove all usages of deprecated AST methods in the LR parsers.

Comment 17 John Liu

2010-06-08 09:59:19 EDT

(In reply to comment #16)
> (In reply to comment #15)
> Never mind, I mixed up the versions in the diff view. Your patch fixes exactly
> the problem I described. Thanks.
> It'd be good to remove all usages of deprecated AST methods in the LR parsers.

Thanks Markus for checking this.

We will find time to resolve these deprecated functions.