| Summary: | File menus and keyboard shortcuts are always enabled in the Datapool editor. | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Ben Chen <chenbs> |
| Component: | TPTP | Assignee: | Bozier jerome <jerome.bozier> |
| Status: | CLOSED WONTFIX | QA Contact: | Kathy Chan <kathy> |
| Severity: | normal | ||
| Priority: | P2 | CC: | paulslau |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | closed472 | ||
|
Description
Ben Chen
Hi Kathy: since the 3 most recent test report indicates that this test case passed, it could be a regression. Jerome, Please take a look and assess if this is a regression or not. checking what it happening can take some time since Paul is the datapool specialist and i never put my fingers in this code.... ok, i found where code around this is + the manual test cut/copy are expected to be disabled when variable is encrypted (check Test.UI.EncryptedDatapool_editing / Bugzilla_243366_2) after some testing, they are really disabled as expected test case does not talk about shortcut use (CTRL-C/X) so it seems that it never have been tested (it explain why result was green on the 3 previous launch) to make short, it is not a regression, it is a new bug that is not covered by the existing test case (In reply to comment #4) > ok, i found where code around this is + the manual test > > cut/copy are expected to be disabled when variable is encrypted > (check Test.UI.EncryptedDatapool_editing / Bugzilla_243366_2) > after some testing, they are really disabled as expected > > test case does not talk about shortcut use (CTRL-C/X) so it seems that it never > have been tested (it explain why result was green on the 3 previous launch) > > to make short, it is not a regression, it is a new bug that is not covered by > the existing test case Requires the existing test case to be update to cover the file menus and keyboard shortcuts. Of interested but not formally requested by a consuming product. As such, a candidate defect for TPTP 4.7.0.1. In fact, this symptom extends to the Select All, Delete, and Find/Replace file menus and keyboard shortcuts. The problem is that the menus are only enabled when the context menu is about to appear and not when the selection changes in the datapool table. After a closer inspection, the actions (e.g. org.eclipse.hyades.test.ui.datapool.internal.action.CopyAction) are disabled correctly, but not respected by the action handlers for the the file menus and keyboard shortcuts. As such, we would have to overhaul org.eclipse.hyades.ui.internal.editor.action.ActionHandlerListener and org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolActionHandlerListener. Given that our consuming products are not requesting this change and invoking the actions do not corrupt the datapool or expose unencrypted data, we will defer this defect. Insufficient resources to complete. This defect had been resolved as WONTFIX for more than 1 month. Closing this on the reporter's behalf. Please re-open if you have further comment on this issue. Closed in TPTP 4.7.2. |