Bugzilla – Full Text Bug Listing
| Summary: | Modify TRCObject class label and handle null values for sorting comparison | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Joel Cayne <jcayne> | ||||
| Component: | TPTP | Assignee: | Joel Cayne <jcayne> | ||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | ewchan, jgwest, mikereid | ||||
| Version: | unspecified | Flags: | kathy:
pmc_approved?
(oec) kathy: pmc_approved? (ernest) kathy: pmc_approved? (kathy) kathy: pmc_approved? (paulslau) jgwest: pmc_approved+ jgwest: review+ |
||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Jonathan, Can you please review? Thanks! Patch is good! I would like to request PMC approval to include the following fix in TPTP 4.7.0. 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Updates a label for TRCObject in the analysis view and fixes an NPE thrown when a row does not provide a value to sort on. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. No. 4. Does this require new API? No. 5. Who performed the code review? Jonathan 6. Is there a test case attached to the bugzilla record? n/a 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Low - changing a label and returning a result to compare against 0 instead of receiving a null pointer exception. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? n/a Requesting PMC approval for TPTP 4.7. Patch checked into HEAD. Closing. |
Created attachment 170838 [details] Patch to update Label ID and sorting value The class label provided in the Analysis view for TRCObject is currently 'Class Name'.'TPTP Object ID'. This could be updated to be similar to the Debug view format of 'Class Name' (id='TPTP Object ID'). When sorting on an entry for a column that has no value and returns null, a null pointer exception is thrown. Instead of throwing the exception, if the value for the row in the sorted column is null a default value of 0 could be returned for comparison.