Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315414

Summary: Need to add a class to eclipse.org-common
Product: Community Reporter: Eclipse Webmaster <webmaster>
Component: WebsiteAssignee: phoenix.ui <phoenix.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: nathan, wayne.beaton
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
New membership class
none
New management class v2 none

Description Eclipse Webmaster CLA 2010-06-02 11:34:25 EDT
As part of solving bug 231891 I've created a class to handle the magic of getting the image details out of the DB, and inserting the correct values if it can.

This should probably go in classes/membership.

-M.
Comment 1 Eclipse Webmaster CLA 2010-06-02 11:50:20 EDT
Created attachment 170822 [details]
New membership class
Comment 2 Wayne Beaton CLA 2010-06-02 13:12:16 EDT
+1
Comment 3 Nathan Gervais CLA 2010-06-02 14:02:12 EDT
+1 Looks Good Matt
Comment 4 Denis Roy CLA 2010-06-02 14:17:21 EDT
A couple of things:

1. I'd update the copyright header

2. I'd sanitize $_size in your function to avoid SQL injection.  Actually, I believe App has a sqlSanitize function which is a great catch-all.
Comment 5 Eclipse Webmaster CLA 2010-06-02 15:26:41 EDT
The content of attachment 170822 [details] has been deleted by
    Eclipse Webmaster <webmaster@eclipse.org>
who provided the following reason:

obsolete

The token used to delete this attachment was generated at 2010-06-02 15:26:32 EDT.
Comment 6 Eclipse Webmaster CLA 2010-06-02 15:27:41 EDT
Created attachment 170868 [details]
New management class v2

Ok, I've added the sanitize and updated the copyright notice.

-M.
Comment 7 Denis Roy CLA 2010-06-02 16:15:06 EDT
+1
Comment 8 Denis Roy CLA 2010-06-17 11:23:44 EDT
Just doing some triage -- was this committed?
Comment 9 Eclipse Webmaster CLA 2010-06-17 13:28:11 EDT
Yes.

-M.