| Summary: | Need to add a class to eclipse.org-common | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Community | Reporter: | Eclipse Webmaster <webmaster> | ||||||
| Component: | Website | Assignee: | phoenix.ui <phoenix.ui-inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | nathan, wayne.beaton | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Eclipse Webmaster
Created attachment 170822 [details]
New membership class
+1 +1 Looks Good Matt A couple of things: 1. I'd update the copyright header 2. I'd sanitize $_size in your function to avoid SQL injection. Actually, I believe App has a sqlSanitize function which is a great catch-all. The content of attachment 170822 [details] has been deleted by Eclipse Webmaster <webmaster@eclipse.org> who provided the following reason: obsolete The token used to delete this attachment was generated at 2010-06-02 15:26:32 EDT. Created attachment 170868 [details]
New management class v2
Ok, I've added the sanitize and updated the copyright notice.
-M.
+1 Just doing some triage -- was this committed? Yes. -M. |