Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315380

Summary:

Navigationtree is broken after keyboard shortcut is used

Product:

[RT] Riena

Reporter:

Steffen Kriese <steffen.kriese>

Component:

Assignee:

Elias Volanakis <elias>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

christian.campo, elias

Version:

unspecified

Target Milestone:

2.0.0.RC4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none
Updated patch	none

Description Steffen Kriese

2010-06-02 07:51:08 EDT

In our Riena-Application we have a couple of keyboard shortcuts like Strg+S for save and Strg+O for open. If the user enters one of the defined shortcuts the Navigationtree does not activate any other then the previous selected SubModule. But if afterwards any other Key is pressed the Navigationtree works again.

Comment 1 Thorsten Schenkel

2010-06-02 08:10:23 EDT

If has added to keyboard shortcuts to the SWT Example Client of Riena. So this bug is also reproducible with the Riena Example.
The command Zoom In and Zoom Out have the shortcuts CTRL+I and CTRL+O.
After using one of this shortcuts a message box is displayed and no selection in the sub-module tree of the current module activates another sub-module.
If use select these menu items with the mouse, everything works fine.
I also tested the shortcuts F8 and F9. This works fine.
Shortcut SHIFT+ALT+I doesn't work.

Comment 2 Elias Volanakis

2010-06-02 16:25:02 EDT

I've identified the problem in ModuleNavigationListener. Basically keyReleased() is not called after keyPressed() - if another dialog (shell) is opened because of the key combination. 

Since Ctrl+I opens a new dialog (Shell) the keyReleased(...) method is never called, and the result is that keyPressed is left set to true (would be false after keyReleased). Because of that clicks are ignored until the next key press (which resets keyReleased)

Normal run:

[user presses key]
keyPressed() { keyPressed = true }
[user releases key]
keyReleased() { keyPressed = false }

Ctrl+I:

[Ctrl+I]
keyPressed()
Dialog opens
[user releases key]

Will prepare a patch next...

Comment 3 Elias Volanakis

2010-06-02 17:49:26 EDT

Created attachment 170888 [details]
patch

@Christian: please review attached patch.

This should be commited to HEAD and release branches.

Comment 4 Elias Volanakis

2010-06-03 15:28:33 EDT

Created attachment 171009 [details]
Updated patch

Addresses the issue of clicking in the the tree when a key (example shift) is pressed. 

The submodule will be activated when releasing the key (if desired this could be done differently - for example when releasing the mouse button - however this way only the most minimal change is needed)

Comment 5 Christian Campo

2010-06-04 14:00:48 EDT

patch looks good, thanks elias. fixed in HEAD and release branch