Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315338

Summary: [keybinding] Keys for Remove from Context and Mark as Landmark doesn't work
Product: z_Archived Reporter: Marc-André Laperle <malaperle>
Component: MylynAssignee: Shawn Minto <shawn.minto>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P2 CC: antonel.pazargic, davidmichaelkarr, eclipse-bugs, leo.dos.santos, pd, shawn.minto, tomasz.zarna, wesley.coelho
Version: unspecified   
Target Milestone: 3.5   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch
none
mylyn/context/zip
none
updated patch none

Description Marc-André Laperle CLA 2010-06-01 23:49:36 EDT 
Using Eclipse 3.6.0 RC3 I20100527-1700 on Windows and Mac
Mylyn 3.4.0.I20100528

Steps to reproduce:

1. Create a task, activate it
2. Open a couple of files in Package Explorer
3. Try to Remove from Context using Ctrl+Alt+Shift+down or Mark as Landmark using Ctrl+Alt+Shift+up
Comment 1 Steffen Pingel CLA 2010-06-02 00:26:31 EDT 
I can't reproduce this problem on Linux. The key-bindings work as expected. 

Shawn, Leo, can you try on Mac and Windows?
Comment 2 Mark Kirchner CLA 2010-06-02 03:23:16 EDT 
I can reproduce this on Windows (for quite some time now).

Could this be somehow related to bug 306173? I think I started experiencing both problems at about the same time.
Comment 3 Leo Dos Santos CLA 2010-06-02 12:57:54 EDT 
Works for me on Mac
Comment 4 Tomasz Zarna CLA 2010-06-09 06:29:20 EDT 
It's caused by bug 300526[1] which affected Team (bug 306173, mentioned in comment 2) and Mylyn (this bug).

[1] see bug 300526, comment 19 for more details
Comment 5 Shawn Minto CLA 2010-07-09 14:00:48 EDT 
*** Bug 319404 has been marked as a duplicate of this bug. ***
Comment 6 Steffen Pingel CLA 2010-07-09 22:22:45 EDT 
Tentatively scheduling for 3.4.1 to investigate if the platform fix for bug 300526 will address this problem.
Comment 7 Steffen Pingel CLA 2010-09-15 14:19:08 EDT 
We didn't get around to fixing this. Need to defer to 3.4.3.
Comment 8 Steffen Pingel CLA 2011-01-29 22:12:56 EST 
Unfortunately we won't get to doing this for the maintenance release. Moving forward to 3.5 release.
Comment 9 Marc-André Laperle CLA 2011-02-12 14:00:10 EST 
Would it be too late for 3.5 if I try to make a patch soon? I feel like this is an important issue.
Comment 10 Steffen Pingel CLA 2011-02-12 21:39:05 EST 
If you can keep the size of the patch to less than 250 lines (to avoid an IP review) and submit it within the next week I'd be happy to try to get it in for 3.5.
Comment 11 Shawn Minto CLA 2011-03-11 20:09:30 EST 
Created attachment 191038 [details]
patch

Steffen, want to have a look at this?  I haven't tested this on any platform than 3.6, but I think that this should work for users in the package and project explorer.  Note that the keybindings will still not work in the context page due to the selection always being the task.
Comment 12 Shawn Minto CLA 2011-03-11 20:09:32 EST 
Created attachment 191039 [details]
mylyn/context/zip
Comment 13 Steffen Pingel CLA 2011-03-12 16:28:16 EST 
Created attachment 191058 [details]
updated patch
Comment 14 Steffen Pingel CLA 2011-03-12 16:35:38 EST 
I have committed the patch to the e_3_7_m_3_7_x branch and triggered a new build: https://hudson.eclipse.org/hudson/job/mylyn-release/78/. I'll do some testing on 3.5 and will revert if I run into any problems.
Comment 15 Steffen Pingel CLA 2011-03-12 18:21:09 EST 
I have done some quick testing on 3.5, 3.6 and 3.7 and it looks the key-bindings generally works except for the context editor page. I have open bug 339808 to track that. Marking resolved as the bulk of the work is done. Thanks for looking into this Shawn!