Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315307

Summary: [LTTng, TMF] Ensure all strings are externalized
Product: z_Archived Reporter: Andrew Overholt <overholt>
Component: LinuxToolsAssignee: Francois Chouinard <fchouinard>
Status: CLOSED FIXED QA Contact: Francois Chouinard <fchouinard>
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Part 1
fchouinard: iplog-
Part 2
fchouinard: iplog-
Part 3
fchouinard: iplog-
Part 4 fchouinard: iplog-

Description Andrew Overholt CLA 2010-06-01 17:15:34 EDT 
While testing bug #313161, I noticed that some strings (notably the table headers in the Events and Statistics views and the labels in the Histogram view) aren't externalized.
Comment 1 Francois Chouinard CLA 2010-06-09 01:07:51 EDT 
Postponed to 0.6.1
Comment 2 Francois Chouinard CLA 2010-11-09 10:33:11 EST 
Created attachment 182728 [details]
Part 1

This is the first contribution to this bug.

After "warnifying" the compiler's "Non-externalized strings" code style, ~4000 warnings popped-up :-(

This patch doesn't address the main issue but clears up a large number of warnings by adding @SuppressWarning annotations to cover the following cases:

- all test code
- all tracing code
- all toString() methods
- all exception messages (they will be re-visited anyway)
- all punctuation strings (this might not be that kosher...)
- all internal constants (Eclipse IDs, default file names, paths, ...)
Comment 3 Francois Chouinard CLA 2010-11-10 10:26:25 EST 
Created attachment 182818 [details]
Part 2

Second round of fixes.
Comment 4 Francois Chouinard CLA 2010-11-19 19:05:59 EST 
Created attachment 183509 [details]
Part 3
Comment 5 Francois Chouinard CLA 2010-11-21 14:27:14 EST 
Created attachment 183540 [details]
Part 4

Final part.
Comment 6 Francois Chouinard CLA 2010-11-22 10:10:43 EST 
Comment on attachment 183540 [details]
Part 4

Patch committed on Indigo
Comment 7 Francois Chouinard CLA 2010-11-22 10:15:04 EST 
All strings are now either externalized or tagged with $NON-NLS$. The only "UI" strings that are not extracted in the various messages.properties files are for the exceptions.
Comment 8 Francois Chouinard CLA 2011-07-22 14:34:22 EDT 
Delivered with 0.7