Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315303

Summary:

Externalize "SystemTap" preferences category string

Product:

[Tools] Linux Tools

Reporter:

Andrew Overholt <overholt>

Component:

Systemtap

Assignee:

anithra <anithra>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

pmuldoon, rgrunber, sgehwolf

Version:

unspecified

Target Milestone:

0.6

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Andrew Overholt

2010-06-01 17:07:14 EDT

While verifying bug #313161, I came across a string that wasn't externalized.  I'll attach a stab at a patch.

Comment 1 Andrew Overholt

2010-06-01 17:09:27 EDT

Actually, I see a few strings in the various SystemTap plugin.xml files.  Please externalize them.

Comment 2 Andrew Overholt

2010-06-04 17:28:44 EDT

It looks like this was already done.  I can see it externalized as of revision 23786 but with the latest Babel build (20100604-0400) it isn't externalized.  Anyone have any ideas?

Comment 3 Andrew Overholt

2010-06-08 10:50:36 EDT

Roland, do you have any ideas here?

Comment 4 Roland Grunberg

2010-06-08 13:44:02 EDT

Created attachment 171434 [details]
Patch

This should fix the issue.

Comment 5 Andrew Overholt

2010-06-08 13:45:52 EDT

Nice catch, Roland.  +1 to the fix.

Comment 6 Roland Grunberg

2010-06-08 13:53:55 EDT

Revision 24983.

Comment 7 Andrew Overholt

2010-06-08 14:55:37 EDT

I know we won't be able to verify with Babel right now, but can you see if things are externalized as you expect, Roland?  Thanks.

https://build.eclipse.org/hudson/job/cbi-linuxtools-Helios/235/

Comment 8 Roland Grunberg

2010-06-08 15:28:38 EDT

The string 'SystemTap' is externalized as expected.

Comment 9 Andrew Overholt

2010-06-08 15:38:36 EDT

Thanks, Roland.

Comment 10 Andrew Overholt

2011-06-06 15:29:37 EDT

Comment on attachment 171434 [details]
Patch

Marking patch obsolete since it was done by a committer.