Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315301

Summary:

[callgraph] Externalize a few more strings

Product:

[Tools] Linux Tools

Reporter:

Andrew Overholt <overholt>

Component:

Call Graph

Assignee:

Roland Grunberg <rgrunber>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

anithra, charley.wang, pmuldoon

Version:

unspecified

Target Milestone:

0.6

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
potential patch	none

Description Andrew Overholt

2010-06-01 17:00:03 EDT

While investigating bug #313161 I came across some un-externalized strings in the callgraph plugins.  I'll attach a proposed (untested) patch.

Comment 1 Andrew Overholt

2010-06-01 17:01:30 EDT

Created attachment 170708 [details]
potential patch

I don't think this patch works out of the box but it should be a decent start.

Comment 2 Roland Grunberg

2010-06-01 17:21:03 EDT

It applied, but I'll go ahead and make the same changes to the other callgraph plugins.

Comment 3 Roland Grunberg

2010-06-02 11:05:17 EDT

Revision 24939 should fix string externalization within the manifest-related files.

Comment 4 Andrew Overholt

2010-06-02 12:59:25 EDT

Until a new Babel build is done, it'll be hard to verify like in bug 313161.  Please verify with tomorrow's Babel build.  Thanks.

Comment 5 Roland Grunberg

2010-06-04 11:47:16 EDT

Confirmed using same approach as mentioned in #315400

Comment 6 Andrew Overholt

2010-06-04 14:40:01 EDT

Thanks, Roland.