Bugzilla – Full Text Bug Listing
| Summary: | Implement e4 minimize/maximize behavior | ||
|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Eric Moffatt <emoffatt> |
| Component: | UI | Assignee: | Project Inbox <e4.ui-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | Eric Moffatt <emoffatt> |
| Severity: | normal | ||
| Priority: | P3 | CC: | bokowski, remy.suen |
| Version: | unspecified | ||
| Target Milestone: | 1.0 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
Eric Moffatt
Created attachment 170694 [details]
Part 1: Minimize a PartStack
This is definitely a work in progress but this patch allows you to minimize a ParStack.
What's in:
Minimize a stack..goes to the TOP trim only for
Allows click on an item to show the stack
bringToTop shows the stack
Switching perspectives will tear down any showing minimized stack and also show/hide stacks based on the perspective.
To close the stack you currently have to click outside its bounds but inside the MWindow.
What's not in:
Sending the TrimStack to the correct 'side'
Updating the TrimStack when views come/go/update state
No DnD, either for views within the TrimStack or the trim control itself.
Remy, if you could kick this around a bit I'd really appreciate it. I'm more interested if you can get into a 'broken' state rather than polish issues at this point (I know there are a few...at least...;-). (In reply to comment #2) > Remy, if you could kick this around a bit I'd really appreciate it. I'm more > interested if you can get into a 'broken' state rather than polish issues at > this point (I know there are a few...at least...;-). Eric, I tried the patch a bit last night on my Windows 7 machine. I didn't see any obvious problems like exceptions being logged to the console. It seems kind of annoying that clicking one view in one stack and then another causes the shell to go down and back up even though the shell's showing the whole stack but I guess that's technically the same behaviour that happens on 3.x minus the display of the entire stack. Thanks Remy, that is just one of the polish issues I'll try to address today. One thing that I don't know how to solve is 'giving up' the active part when I close the minimized stack. Right now I just leave whatever part was active alone but it should really go back to some view/editor visible in the presentation. Created attachment 171000 [details]
Patch to implement minimize behavior
Seems pretty complete except that we need a way to cause the PartService to select a new active part once a 'fast stack' is made invisible...
Created attachment 171832 [details]
Patch that puts minimized stacks only in the left/rigth trims areas
Committed in >20100614. Applied the patch. Created attachment 172141 [details]
Patch to fix an issue on the Mac
Had to slightly revamp the code to allow for a mac defect (Bogdan's opening that one).
Committed in >20100617. Applied the patch. Created attachment 172219 [details]
Allow toggling the stack by clicking on the toolbar button
Clicking on the 'selected' view in a minimized stack that is currently visible should tear it down.
Committed in >20100618. Applied the patch. Created attachment 172247 [details]
Patch to fix restart errors
Under certain conditions the minimized stacks were not appearing on a restart.
Marking for work in RC1. Created attachment 172657 [details]
Switch over to using a Composite wirh custom sizing behavior
Committed in >20100624. Applied the patch. There's still some work to be done on: Keeping the hostPane in synch with size changes to the main shell Handling closing the last view Handle dragging the last view out of the stack Created attachment 172659 [details]
Keep any showing hostPane synch'd with window changes
Committed in >20100624. Applied the patch. (In reply to comment #17) > Committed in >20100624. Applied the patch. |