Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315269

Summary:

"constructorFunction" and "prototypeObject" attributes should not be serialized objects

Product:

[WebTools] JSDT

Reporter:

Michael Rennie <Michael_Rennie>

Component:

Debug

Assignee:

Michael Rennie <Michael_Rennie>

Status:

RESOLVED FIXED

QA Contact:

Simon Kaegi <simon_kaegi>

Severity:

normal

Priority:

CC:

thatnitind

Version:

3.2

Target Milestone:

3.3 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
fix	none

Description Michael Rennie

2010-06-01 14:09:56 EDT

code from HEAD

consider the following evaluate response:

1971
\r\n
{
  "command":"evaluate",
  "type":"response",
  "request_seq":12,
  "seq":13,
  "running":true,
  "success":true,
  "body":{
          "evaluate":{
                      "handle":1,
                      "constructorFunction":{"ref":2},
                      "prototypeObject":{"ref":3},
                      "className":"Object",
                      "properties":[
                                    {"ref":6,"name":"line6"},
                                    ..<snip>..,
                                    {"ref":61,"name":"line1"}],
                      "type":"object"
                     }
          }
}

"constructorFunction":{"ref":2} does not need to be a serialized object, it should follow suit with other id-able items and just be "constructorFunction":2. The same change should be made for "prototypeObject":{"ref":3} -> "prototypeObject":3

Comment 1 Michael Rennie

2010-07-30 00:39:01 EDT

Created attachment 175538 [details]
fix

the patch changes the two attributes to be simply numbers and not serialized objects. This increases parsing performance for ObjectReferences and decreases packet size.

Comment 2 Michael Rennie

2010-07-30 00:40:01 EDT

applied patch to HEAD