Bugzilla – Full Text Bug Listing
| Summary: | [CSS] Remember Active ThemeId as Preference | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Thomas Schindl <tom.schindl> | ||||||||||
| Component: | UI | Assignee: | Project Inbox <e4.ui-inbox> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | bokowski, gheorghe, john.arthorne, pwebster | ||||||||||
| Version: | 1.0 | ||||||||||||
| Target Milestone: | 1.0 RC0 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
Boris, Bodgan do you think the preference should be part of the theme-bundle or better part of ui.workbench.swt? Created attachment 171741 [details]
patch
This patch introduces the new cssTheme-Parameter to use for themes but supports the old applicationCSS until all customers switched to this new style.
The preference is read out and used instead of the plugin.xml value. If we are ok with this patch then I'll release it and send out a mail to e4-dev
I've released the patch from above so that it gets into the build Created attachment 171784 [details]
Update for 4.0 SDK
John or Paul, I think you've got commit rights on org.eclipse.platform. Can you apply the patch "Update for 4.0 SDK" please. Created attachment 171785 [details]
Update for 4.0 SDK
Just for information. I've now reactivated applicationCSS-switch which makes sense for very small RCP-Application where setup up our Themeing stuff is overkill (e.g. our photo-Demo is not using our Themeing stuff). Beside that I've extended the Extension Point to allow people to contribute OSGIResource Lookup URIs (In reply to comment #6) > Created an attachment (id=171785) [details] > Update for 4.0 SDK Released for tonight's build. PW now that the changes to SDK are released marking as fixed |
Created attachment 170665 [details] Patch If the user switches the theme actively we should remember this setting and discard the branding parameter.