Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315233

Summary:

Inconsistent use of "line" and "lineNumber" in JSON

Product:

[WebTools] JSDT

Reporter:

Michael Rennie <Michael_Rennie>

Component:

Debug

Assignee:

Michael Rennie <Michael_Rennie>

Status:

RESOLVED FIXED

QA Contact:

Simon Kaegi <simon_kaegi>

Severity:

normal

Priority:

CC:

thatnitind

Version:

3.2

Target Milestone:

3.3 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
fix	none

Description Michael Rennie

2010-06-01 10:55:13 EDT

code from HEAD

I found that when referencing a line number in JSON we use either "line" or "linenumber" we should use one only - I vote "line"

Examples:

the break event - "lineNumber" usage:

143
\r\n
{
  "type":"event",
  "seq":17,
  "event":"break",
  "body":{
          "contextId":0,
          "debuggerStatement":false,
          "threadId":1,
          "step":"in",
          "lineNumber":2,
          "scriptId":1}
}

the setbreakpoint request - "line" usage:

107
\r\n
{
  "command":"setbreakpoint",
  "seq":51,
  "type":"request",
  "arguments":{
               "condition":null,
               "line":10,
               "scriptId":1
              }
}

Comment 1 Michael Rennie

2010-07-30 00:28:19 EDT

Created attachment 175537 [details]
fix

Removes the use of the attribute 'lineNumber' in favour of 'line'

Comment 2 Michael Rennie

2010-07-30 00:29:06 EDT

applied patch to HEAD