Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315200

Summary: Change in BIRT interface causing a build failure
Product: z_Archived Reporter: Joel Cayne <jcayne>
Component: TPTPAssignee: Bozier jerome <jerome.bozier>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: blocker    
Priority: P1 CC: ernest, jgwest, kathy, oec, paulslau
Version: unspecifiedFlags: kathy: pmc_approved? (oec)
ernest: pmc_approved+
kathy: pmc_approved? (kathy)
kathy: pmc_approved? (paulslau)
kathy: pmc_approved? (jgwest)
jcayne: review+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch none

Description Joel Cayne CLA 2010-06-01 08:33:30 EDT 
The build is failing due a change in the BIRT interface API as part of bug 313652.

The build failure is:
ERROR in /tmp/workspace/plugins/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/forms/base/SystemStyleProcessor.java (at line 31)
    public class SystemStyleProcessor implements IStyleProcessor {
                 ^^^^^^^^^^^^^^^^^^^^
The type SystemStyleProcessor must implement the inherited abstract method IStyleProcessor.processStyle(Chart)
----------
ERROR in /tmp/workspace/plugins/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/forms/base/SystemStyleProcessor.java (at line 31)
    public class SystemStyleProcessor implements IStyleProcessor {
                 ^^^^^^^^^^^^^^^^^^^^
The type SystemStyleProcessor must implement the inherited abstract method IStyleProcessor.setDefaultBackgroundColor(ColorDefinition)
----------
ERROR in /tmp/workspace/plugins/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/forms/base/SystemStyleProcessor.java (at line 31)
    public class SystemStyleProcessor implements IStyleProcessor {
                 ^^^^^^^^^^^^^^^^^^^^
The type SystemStyleProcessor must implement the inherited abstract method IStyleProcessor.getDefaultBackgroundColor()
Comment 1 Bozier jerome CLA 2010-06-01 08:38:04 EDT 
upgrading priority as no build can be performed until it is fixed

working on it
Comment 2 Bozier jerome CLA 2010-06-01 09:38:18 EDT 
Created attachment 170634 [details]
patch

this patch complete the class SystemStyleProcessor that was no longer compiling

from the first tests i made, it seems to break nothing even if i must admit that i don't know what to do in one of theses new method (ProcessStyle(...) to be precise)
Comment 3 Joel Cayne CLA 2010-06-01 09:49:08 EDT 
Patch looks good.
Comment 4 Kathy Chan CLA 2010-06-01 09:57:46 EDT 
I would like to request that the following defect be considered for PMC
approval for 4.7.0.

1.  Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

This is a must fix since the build breaks without this change.

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?
No.

3. Is this a regression or API breakage? Explain.
Yes.  This is a regression brought in by a change BIRT checked in as part of bug 313652.

4. Does this require new API?
No.

5. Who performed the code review?
Joel

6. Is there a test case attached to the bugzilla record?
No.  

7. What is the nature of the fix?  What is the risk associated with this fix?
Low.  This fix implements the new methods introduced by BIRT in bug 313652.

8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?
No.
Comment 5 Kathy Chan CLA 2010-06-01 10:00:20 EDT 
Requesting PMC approval for TPTP 4.7.
Comment 6 Joel Cayne CLA 2010-06-01 11:15:40 EDT 
Patch checked into HEAD.
Comment 7 Joel Cayne CLA 2010-06-01 11:16:36 EDT 
This is included in the build TPTP-4.7.0-201006011014.
Comment 8 Bozier jerome CLA 2010-06-01 11:36:00 EDT 
updating worked hours + closing
Comment 9 Kathy Chan CLA 2010-06-02 14:25:29 EDT 
Bug 315444 had been opened on BIRT to confirm this API change.