Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315192

Summary:

[CompD] - Association between classes nested in component is doubled after creation

Product:

[Modeling] GMF-Tooling

Reporter:

Christian Waniek <chris.waniek>

Component:

Samples

Assignee:

Michael Golubev <borlander>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

borlander, eshaverdova

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Picture of crashed diagram	none
fixes the subj	borlander: iplog+, borlander: review+

Description Christian Waniek

2010-06-01 08:05:20 EDT

Build Identifier: 

I get a nasty diagram when I try to create a reflexive association on a class, which is nested in a component (see atached screenshot).
In the diagram file occur TWO edge-definitions, but the model file correct, so when you close and reopen the diagram everything works fine.
But if you are shocked by the two associations and you want to remove them (or at least one of them), you'll get an entry in the eclipse error log and you can do nothing but close the diagram.

I haven't been able to get the problem source to provide a fix. Also I don't know whether this is a U2T bug or if it relates to GMF.

Reproducible: Always

Steps to Reproduce:
1. Create a Component
2. nest a Class c in the Component
3. crate an association from c to c

Comment 1 Michael Golubev

2010-06-01 08:26:00 EDT

Mentioned screenshot would definitely help. 

severity -> normal, no formal reasons for major category.

Comment 2 Michael Golubev

2010-06-01 09:02:06 EDT

Severity: back, normal -> major, user data loss, the whole diagram is broken

Steps to repeat: 
1. create component on CompD, 
2. create classed A, B inside the component 
3. draw association between A and B

=> 
there are 2 different associations between A and B shown at the diagram. 

4. select one of the associations and delete it
=> 
Nothing happens, exception in log. But now its impossible to reopen this diagram : any reopen attempt fails with: 

java.lang.ClassCastException: org.eclipse.uml2.uml.internal.impl.PackageImpl cannot be cast to org.eclipse.uml2.uml.Association
	at org.eclipse.uml2.diagram.component.edit.parts.AssociationEditPart.addSemanticListeners(AssociationEditPart.java:108)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.ConnectionEditPart.activate(ConnectionEditPart.java:253)
	at org.eclipse.gef.editparts.AbstractGraphicalEditPart.activate(AbstractGraphicalEditPart.java:196)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.access$0(GraphicalEditPart.java:1)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.activate(GraphicalEditPart.java:205)
	at org.eclipse.gef.editparts.AbstractEditPart.activate(AbstractEditPart.java:152)
	at org.eclipse.gef.editparts.AbstractGraphicalEditPart.activate(AbstractGraphicalEditPart.java:193)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.access$0(GraphicalEditPart.java:1)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.activate(GraphicalEditPart.java:205)
	at org.eclipse.gef.editparts.AbstractEditPart.activate(AbstractEditPart.java:152)
	at org.eclipse.gef.editparts.AbstractGraphicalEditPart.activate(AbstractGraphicalEditPart.java:193)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.access$0(GraphicalEditPart.java:1)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.activate(GraphicalEditPart.java:205)
	at org.eclipse.gmf.runtime.diagram.ui.editpolicies.CanonicalConnectionEditPolicy.refreshOnActivate(CanonicalConnectionEditPolicy.java:106)
	at org.eclipse.gmf.runtime.diagram.ui.editpolicies.CanonicalEditPolicy.activate(CanonicalEditPolicy.java:628)
	at org.eclipse.gef.editparts.AbstractEditPart.activateEditPolicies(AbstractEditPart.java:165)
	at org.eclipse.gef.editparts.AbstractEditPart.activate(AbstractEditPart.java:148)
	at org.eclipse.gef.editparts.AbstractGraphicalEditPart.activate(AbstractGraphicalEditPart.java:193)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.access$0(GraphicalEditPart.java:1)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.GraphicalEditPart.activate(GraphicalEditPart.java:205)
	at org.eclipse.gmf.runtime.diagram.ui.editparts.DiagramEditPart.activate(DiagramEditPart.java:349)
	at org.eclipse.gef.editparts.AbstractEditPart.addChild(AbstractEditPart.java:201)

Comment 3 Christian Waniek

2010-06-01 11:53:46 EDT

Created attachment 170651 [details]
Picture of crashed diagram

Comment 4 Elena Shaverdova

2010-06-04 12:49:41 EDT

Created attachment 171127 [details]
fixes the subj

Comment 5 Michael Golubev

2010-06-05 07:52:16 EDT

Comment on attachment 171127 [details]
fixes the subj

reviewed

Comment 6 Michael Golubev

2010-06-05 08:10:45 EDT

Patch committed with minor changes. Fixed now