Bugzilla – Full Text Bug Listing
| Summary: | [AllDiagrams] - Updater: code generated with 3.6RC uses fully qualified names for descriptors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] GMF-Tooling | Reporter: | Michael Golubev <borlander> | ||||
| Component: | Samples | Assignee: | Elena Shaverdova <eshaverdova> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 170626 [details]
fixes the subj
Comment on attachment 170626 [details]
fixes the subj
reviewed, big but primitive change, no risk
Patch committed for structure/behavior diagrams Fixed now, regeneration of the diagrams does not produces diffs for diagram updater. |
Actually, after regeneration with GMF for 3.6RC, all UmlDiagramUpdater's contains the fully qualified names for UMLNodeDescriptor/UMLLinkDescriptor, like in the following snippet: public static List<org.eclipse.uml2.diagram.activity.part.UMLNodeDescriptor> getActivity_2026SemanticChildren(View view) { for the old code, the type parameters were processed by the Organize Imports operation, so the same snippet was : public static List<UMLNodeDescriptor> getActivity_2026SemanticChildren(View view) { it creates a huge diff for regeneration, without adding any structural/meaningful differences. => Either force Organize imports operation to process type parameteres, or commit the big generation diff in single commit (once) which does not include amy other changes.