Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315175

Summary:

Please provide icon decoration for dirty

Product:

[Technology] EGit

Reporter:

Gunnar Wagenknecht <gunnar>

Component:

Assignee:

Benjamin Muskalla <b.muskalla>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

mathias.kinzler, matthias.sohn, mn, remy.suen, robert.munteanu, robin, stefan.lay

Version:

unspecified

Target Milestone:

2.0

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Screenshot	none

Description Gunnar Wagenknecht

2010-06-01 03:33:22 EDT

Build 0.8.0.201005271234

Currently, the only way to recognize dirty files is using a text decoration. It should be possible to also use an icon decoration for this. 

My vote would be to use the 'dirty' icon that other providers (such as CVS and SVN) use. However, then [ partially-]staged files need a new icon. They should probably also use different icons to allow switching of the dirty text decoration.

Comment 1 Glen A.

2010-06-06 06:30:55 EDT

The text decoration is ugly.

Comment 2 Matthias Sohn

2010-06-10 16:12:35 EDT

enhancement request

Comment 3 Benjamin Muskalla

2010-08-25 11:36:19 EDT

Code review at http://egit.eclipse.org/r/#change,1420
In case someone has a good idea for a dirty icon overlay, contributions are welcome :)

Comment 4 Mathias Kinzler

2010-08-25 12:43:21 EDT

Merged as 60ad0407f9ae1cbfadc30992337c4d2b07fa7025

Comment 5 Stefan Lay

2010-08-30 09:12:44 EDT

Now "dirty" and "partially-staged" have the same icon. 

Gunnar already stated this: 

"However, then [ partially-]staged files need a new icon. They should
probably also use different icons to allow switching of the dirty text
decoration."

We should think about a new icon for staged and for partially-staged (the latter one maybe some combination of dirty and staged.)

Comment 6 Gunnar Wagenknecht

2010-09-02 03:48:17 EDT

(In reply to comment #5)
> Now "dirty" and "partially-staged" have the same icon. 

There is a subtle color change. It's probably not enough.

> We should think about a new icon for staged and for partially-staged (the
> latter one maybe some combination of dirty and staged.)

+1

The current "staged" icon is commonly used for "dirty" by other team providers. Thus, EGit should honor the common pattern and use that for "dirty" as well.

Comment 7 Gunnar Wagenknecht

2010-09-02 03:53:21 EDT

Created attachment 178021 [details]
Screenshot

What's still not working is that the parent folder is decorated "dirty" when it contains untracked children. See attached screenshot.

I just committed some changes, went to the preferences, enabled the dirty icon decorations and disabled the text decorations. I then clicked Apply+OK. However, the parent still isn't decorated. Even a project close+open didn't work.

Comment 8 Mykola Nikishov

2012-03-03 11:12:55 EST

[Batch change] Remove passed Target Milestones

If anyone on CC list is going to fix/implement this, feel free to assign a new, post-1.3/2.0, target milestone.

Comment 9 Robin Stocker

2013-05-03 12:53:43 EDT

(In reply to comment #7)
> What's still not working is that the parent folder is decorated "dirty" when
> it contains untracked children. See attached screenshot.

This has been implemented in bug 345099 -> resolved.