Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315160

Summary: feature image is missing
Product: [Eclipse Project] Equinox Reporter: Kit Lo <kitlo>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: irbull, pwebster, remy.suen, stephen.francisco, susan
Version: 3.6   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Eclipse 3.3
none
Eclipse 3.6
none
feature properties in Eclipse 3.3
none
platform properties in 3.6 none

Description Kit Lo CLA 2010-06-01 00:23:45 EDT
Created attachment 170603 [details]
Eclipse 3.3

The feature logo image, specified by the image="eclipse_update_120.jpg" attribute in the feature definition of the feature.xml file, was displayed next to the feature info in older Eclipse releases (e.g. Eclipse 3.3). However, it's misisng in Eclipse 3.6.

If the "image" attribute is still supported in 3.6, then the image should be displayed. If the design is changed and the image will no longer be displayed, then the "eclipse_update_120.jpg" files should probably be removed from all features.
Comment 1 Kit Lo CLA 2010-06-01 00:24:11 EDT
Created attachment 170604 [details]
Eclipse 3.6
Comment 2 Susan McCourt CLA 2010-06-03 18:50:10 EDT
Can you describe the steps you took to view the properties in the first screenshot?

The second screenshot is for the properties view of items in the installation details page, which did not exist in 3.3.  

It coincidentally has much of the same information as that in the first screenshot.  But the first screenshot appears to be some kind of feature properties page.
Comment 3 Kit Lo CLA 2010-06-03 22:16:24 EDT
Created attachment 171058 [details]
feature properties in Eclipse 3.3

Please see the attached screenshots on the steps to get to the feature properties dialog in Eclipse 3.3.
Comment 4 Paul Webster CLA 2010-06-04 07:36:03 EDT
Created attachment 171086 [details]
platform properties in 3.6

This is the properties from the Platform feature, that matches Kit's first 3.3 selection, but it is not from the Feature tab but the properties from the Installed Software tab.

Did displaying the icon move from the properties to the lower section of the feature tab?

PW
Comment 5 Susan McCourt CLA 2010-06-09 12:49:16 EDT
(In reply to comment #4)
> Created an attachment (id=171086) [details]
> platform properties in 3.6
> 
> This is the properties from the Platform feature, that matches Kit's first 3.3
> selection, but it is not from the Feature tab but the properties from the
> Installed Software tab.
> 
> Did displaying the icon move from the properties to the lower section of the
> feature tab?
> 
> PW

Thanks for the screenshots, Kit.  I couldn't figure out where the feature properties were made available in the about dialog, but now I see you are talking about the feature properties provided by update manager, which is no longer used.  

So the real question here (a rephrase of your original point) is...
- will p2 support feature images in its metadata?  We currently don't really have an equivalent in p2.  We have a small icon to show in some views, but not a larger one.  
- and if not, should we be removing these feature images in the long run?

So this turns out to be a duplicate of bug 252014

*** This bug has been marked as a duplicate of bug 252014 ***