Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315146

Summary: disable / grey out unavailable popup / context menu commands
Product: [Technology] EGit Reporter: Kay Huber <quorg.xtn>
Component: UIAssignee: Mathias Kinzler <mathias.kinzler>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: stefan.lay
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:

Description Kay Huber CLA 2010-05-31 16:36:47 EDT 
Referring to latest nightlies of both EGit (0.8.0.201005300830) and JGit (0.8.0.201005300828).

In Package Explorer, right clicking a git managed project, in the "Team" menu, offers me to "Add" the project to git. 
Also, "Commit" is enabled even without the project having any changes to commit.

It may be more helpful to users, to grey out unavailable or "useless" commands.
Comment 1 Mathias Kinzler CLA 2010-09-03 07:40:37 EDT 
(In reply to comment #0)
> Referring to latest nightlies of both EGit (0.8.0.201005300830) and JGit
> (0.8.0.201005300828).
> 
> In Package Explorer, right clicking a git managed project, in the "Team" menu,
> offers me to "Add" the project to git. 
> Also, "Commit" is enabled even without the project having any changes to
> commit.
> 
> It may be more helpful to users, to grey out unavailable or "useless" commands.

First of all, sorry for the slow response...

1. "Add" works recursively by going down the resource hierarchy (of the project in your case) and "adds" any resources that are currently not under version control. In order to determine a enablement, we would have to do the same, which is too expensive an operation for enablement checking.

2. As for "Commit", the situation for calculating enablement may be not as bad, but we wouldn't want to disable it anyway, as "committing" on a clean workspace will ask the user if they want to amend their previous commit (for example, change the commit message, author, etc.). So in this case, it's working as it should.

So, for the moment, I don't see any issues here. Please do not hesitate to reopen this if you don't agree.