Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315143

Summary:

Put GraphingAPI preference in SystemTap category

Product:

[Tools] Linux Tools

Reporter:

Andrew Overholt <overholt>

Component:

Systemtap

Assignee:

anithra <anithra>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

pmuldoon, rgrunber, sgehwolf

Version:

unspecified

Target Milestone:

0.6

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch	none
proposed patch	none

Description Andrew Overholt

2010-05-31 16:27:15 EDT

The "GraphingAPI" preference should not be a top-level element of the Preferences.  This should be in the SystemTap category.

Comment 1 Roland Grunberg

2010-05-31 16:41:57 EDT

Created attachment 170592 [details]
Patch

Proposed patch to move GraphingApi preference group under SystemTap preference group.

Comment 2 Andrew Overholt

2010-06-04 17:18:14 EDT

Created attachment 171181 [details]
proposed patch

How about this patch which moves all SystemTap preferences into the SystemTap category?

Comment 3 Andrew Overholt

2010-06-04 17:18:47 EDT

Roland, can you review my patch?  It's similar to yours but moves a few more preference pages into the main SystemTap category.  Thanks.

Comment 4 Roland Grunberg

2010-06-04 17:46:26 EDT

This works for me.

Comment 5 anithra

2010-06-06 10:02:19 EDT

Works for me too..

Comment 6 Andrew Overholt

2010-06-07 09:56:22 EDT

Committed.  I'll verify in the next build.

Comment 7 Andrew Overholt

2010-06-07 14:33:32 EDT

I can confirm that all SystemTap-related preferences are now under the SystemTap category.

Comment 8 Andrew Overholt

2010-06-07 14:33:56 EDT

Verified using our N201006071201 build.