Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 315043

Summary: Inconsistent behavior of getRevisionByVersion()
Product: [Modeling] EMF Reporter: Egidijus Vaisnora <vaisegid>
Component: cdo.coreAssignee: Egidijus Vaisnora <vaisegid>
Status: CLOSED FIXED QA Contact: Eike Stepper <stepper>
Severity: normal    
Priority: P3 CC: stepper
Version: 3.0Flags: stepper: review+
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
test
none
patch
none
Test+Fix v2 - ready to be committed
none
binary compatible
none
Patch v4 - ready to be committed none

Description Egidijus Vaisnora CLA 2010-05-31 05:41:47 EDT 
Build Identifier: 3.0

getRevisionByVersion on detached revision returns null or DetachedCDORevision, regarding the local cache.
Expected result, to have method working the same way. 
Perhaps it is worth to consider return DetachedCDORevision for detached revision version and *null* for non existing version

Reproducible: Always

Steps to Reproduce:
test
Comment 1 Egidijus Vaisnora CLA 2010-06-10 04:51:23 EDT 
Created attachment 171615 [details]
test
Comment 2 Egidijus Vaisnora CLA 2010-06-10 07:09:51 EDT 
Created attachment 171626 [details]
patch

Detached revision will be returned, if getRevisionByVersion is called for detached version
Comment 3 Eike Stepper CLA 2010-06-29 04:54:24 EDT 
Rebasing all outstanding 3.0 problem reports to version 3.0.1
Comment 4 Eike Stepper CLA 2010-07-26 05:32:15 EDT 
Created attachment 175205 [details]
Test+Fix v2 - ready to be committed

Looks good ;-)
Comment 5 Eike Stepper CLA 2010-07-28 09:00:51 EDT 
Please do not commit this patch! Investigating whether I've accidentally made this patch against 4.0 (where it belongs, I think)...
Comment 6 Egidijus Vaisnora CLA 2010-08-09 04:49:57 EDT 
Created attachment 176136 [details]
binary compatible

Removed "since 4.0" tags and leaved old methods for binary compatibility
Comment 7 Egidijus Vaisnora CLA 2010-08-09 04:53:35 EDT 
Ready for review
Comment 8 Eike Stepper CLA 2010-08-09 05:46:36 EDT 
Created attachment 176141 [details]
Patch v4 - ready to be committed

I had to add 3 @since tags, no idea why. Anyway ;-)
Comment 9 Egidijus Vaisnora CLA 2010-08-09 06:37:57 EDT 
Committed to  R3_0_maintenance
Comment 10 Eike Stepper CLA 2011-06-23 04:26:51 EDT 
Moving all open problem reports to 4.0
Comment 11 Eike Stepper CLA 2012-09-21 06:51:19 EDT 
Closing.