Bugzilla – Full Text Bug Listing
| Summary: | should remove listener in StructuredContentAssistProcessor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | Michael Spector <spektom> | ||||
| Component: | wst.sse | Assignee: | Nitin Dahyabhai <thatnitind> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Nitin Dahyabhai <thatnitind> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ganoro | ||||
| Version: | 3.2 | Flags: | thatnitind:
review+
|
||||
| Target Milestone: | 3.2.2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | contributed | ||||||
| Attachments: |
|
||||||
according to the Eclipse conventions described in "A bug's life cycle" document (https://bugs.eclipse.org/bugs/page.cgi?id=fields.html#importance) a memory leak issue should be marked as critical. thanks, Roy, Michael, is the problem reproducible in editors other than the PHP Editor? yes Profiling live objects didn't show a leak, and starting from 53MB of use, opening 19 files took me to 152M (after GC), and closing them all took me back down to 63MB. Reopening one file shows one live instance each of StructuredContentAssistProcessor and StructuredTextViewer, as expected. Deferring to 3.2.1 since it's still a good idea. Applied to 3.2.2 and HEAD. Comment on attachment 170456 [details]
patch
Thanks, Michael!
|
Created attachment 170456 [details] patch The listener is not detached in the release() method. This leak is easily detectable when opening/closing editors in PDT.