Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314956

Summary: remove weaving from Target Platform category
Product: [Eclipse Project] Platform Reporter: Jeff McAffer <jeffmcaffer>
Component: RelengAssignee: Kim Moir <kim.moir>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: kim.moir, tjwatson
Version: 3.6Flags: tjwatson: review+
jeffmcaffer: review+
Target Milestone: 3.6 RC4   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
patch
none
patch none

Description Jeff McAffer CLA 2010-05-28 16:28:01 EDT
The Helios RC2 repo has Equinox Weaving as a top level entry.  This should be captured/included in the Equinox Target Components feature and should not appear standalone in the category.
Comment 1 Kim Moir CLA 2010-05-31 13:39:29 EDT
So you're asking me to include the org.eclipse.equinox.weaving.sdk in the org.eclipse.equinox.sdk? Today this feature isn't nested in the equinox sdk and that is why it's listed separately in the Helios build submission.
Comment 2 Jeff McAffer CLA 2010-05-31 13:43:01 EDT
yes.  like all the other sub parts of Equinox.  Weaving is just another sub part.
Comment 3 Jeff McAffer CLA 2010-05-31 13:45:08 EDT
This may actually be a dup of bug 302947.  just found it now...
Comment 4 Kim Moir CLA 2010-05-31 13:56:52 EDT
Bug 302947 requests the addition of the standalone equinox.weaving sdk to the Helios build input.

The current bug is asking for the weaving sdk to be included in the equinox sdk.

I'll create a patch for the current request and ask two component leads to approve.
Comment 5 Kim Moir CLA 2010-05-31 14:11:43 EDT
Created attachment 170572 [details]
patch

I also removed the call to the slicer to create a separate weaving sdk on the equinox download page since it will already be included in the equinox sdk.
Comment 6 Kim Moir CLA 2010-05-31 14:12:27 EDT
Tom, Jeff please approve.
Comment 7 Jeff McAffer CLA 2010-05-31 14:56:57 EDT
indeed you are right.  I was reading too fast.
Comment 8 Thomas Watson CLA 2010-06-01 09:25:42 EDT
+1 thanks Kim.
Comment 9 Kim Moir CLA 2010-06-01 16:23:14 EDT
Released for next integration build.  Since I also have to remove the weaving feature from the equinox.build file for RC4, I'll leave this bug open until we release RC4.
Comment 10 Kim Moir CLA 2010-06-02 13:57:13 EDT
Created attachment 170850 [details]
patch

patch to remove weaving feature from Helios contribution since it will now be included in the equinox sdk.
Comment 11 Kim Moir CLA 2010-06-04 16:59:56 EDT
updated Helios contribution for 3.6RC4, closing.