Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314943

Summary: Write to the message to log instead of console
Product: [Tools] Target Management Reporter: Samuel Wu <samuelwu>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: ankitp, dmcknigh
Version: 3.2Flags: mober.at+eclipse: review+
Target Milestone: 3.2 RC3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
trivial patch to use logWarning instead of System.out.println none

Description Samuel Wu CLA 2010-05-28 14:45:34 EDT 
The method SystemBasePlugin.addWindowListener() will be called once RSE starts. And an exception will be thrown if it's running in the headless mode, which is fine. But it writes a message to the console in the case of exception which is exposed to the end user. This confuses the user. 
Can this message be written to the log?
Comment 1 David McKnight CLA 2010-05-28 16:35:09 EDT 
Created attachment 170429 [details]
trivial patch to use logWarning instead of System.out.println
Comment 2 Martin Oberhuber CLA 2010-05-28 16:43:37 EDT 
Hm... the patch looks OK, but I'm not sure whether I'm going to make another release for rc3. It's pretty much done by now. And this issue is really cosmetic only.

Please do not commit this for now. I can commit the patch in case I do make another release.
Comment 3 David McKnight CLA 2010-05-28 16:45:32 EDT 
(In reply to comment #2)
> Hm... the patch looks OK, but I'm not sure whether I'm going to make another
> release for rc3. It's pretty much done by now. And this issue is really
> cosmetic only.
> 
> Please do not commit this for now. I can commit the patch in case I do make
> another release.

Fair enough, no rush with this. 

Samuel, does this need to be backported?
Comment 4 Samuel Wu CLA 2010-05-28 17:19:29 EDT 
Thank you for the prompt response. There is no need to back port it to 3.0.3.
Comment 5 Martin Oberhuber CLA 2010-05-28 18:45:30 EDT 
Released > I20100528.