Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314925

Summary:

[api] add NodeHelper#getAttributeValueRegion

Product:

[WebTools] JSDT

Reporter:

Ian Tewksbury <itewksbu>

Component:

Web

Assignee:

Project Inbox <jsdt.web-inbox>

Status:

CLOSED WONTFIX

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

normal

Priority:

Version:

3.2

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Ian Tewksbury

2010-05-28 13:55:20 EDT

Right now NodeHelper only has a #getAttributeValue which returns the string value of a given attribute name but it would also be useful to have a #getAttributeValueRegion which would return the ITextRegion with the value.

Patch to follow.

Comment 1 Ian Tewksbury

2010-05-28 13:57:01 EDT

Created attachment 170394 [details]
Patch

This patch moves most of the logic in #getAttributeValue to a new method #getAttributeValueRegion and then calls this new method from the existing #getAttributeValue to prevent any duplicate code.

Comment 2 Nitin Dahyabhai

2010-05-28 15:37:40 EDT

(In reply to comment #0)
> Right now NodeHelper only has a #getAttributeValue which returns the string
> value of a given attribute name but it would also be useful to have a
> #getAttributeValueRegion which would return the ITextRegion with the value.

For what purpose?

Comment 3 Nitin Dahyabhai

2010-05-28 15:50:07 EDT

Doesn't fit the other methods on the class.

Comment 4 Ian Tewksbury

2010-05-28 15:56:25 EDT

closing.