Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314903

Summary:

[JSF2.0] Facelet validator should only validate facelet content type files

Product:

[WebTools] Java Server Faces

Reporter:

Cameron Bateman <cameron.bateman>

Component:

Core

Assignee:

JSF Project Core <jsf.core-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

david_williams, kaloyan, raghunathan.srinivasan, yurykats

Version:

3.2

Flags:

cameron.bateman: pmc_approved?
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
deboer: pmc_approved+
raghunathan.srinivasan: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
raghunathan.srinivasan: review+

Target Milestone:

3.2 RC4

Hardware:

OS:

Windows XP

Whiteboard:

PMC_approved JSF2.0

Attachments:

Description	Flags
Changes the validator criteria to the Facelet content type. Also changes the id of the Facelet content types to the recommended fully qualified format.	none
Broken out just the validator part of the patch. Move the rest to blocking bug.	none
Same patch but with the current content type id used for Facelets.	none

Description Cameron Bateman

2010-05-28 12:06:04 EDT

Currently the validator for Facelets validates all html files in >= JSF2.0 project.  This could cause significant performance problems in the projects that have large numbers of HTML files that are not involved with Facelets.

Comment 1 Cameron Bateman

2010-05-28 12:08:19 EDT

Created attachment 170373 [details]
Changes the validator criteria to the Facelet content type.  Also changes the id of the Facelet content types to the recommended fully qualified format.

Comment 2 Yury Kats

2010-05-28 14:50:54 EDT

There is a separate bug open for content type ID prefix. See bug 314178.
I suggest tracking the two issues separately, as adopters would need to react to ID change, and it's hard to monitor when IDs are being changed under covers of a different issue.

Comment 3 Cameron Bateman

2010-05-28 15:27:17 EDT

Created attachment 170419 [details]
Broken out just the validator part of the patch.  Move the rest to blocking bug.

Comment 4 Raghunathan Srinivasan

2010-05-28 20:06:30 EDT

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
This is a stop-ship bug. For projects with JSF 2.0 facets, this bug will result in bad performance since the JSF Validator will validate all html files in the project and not just those that have JSF 2.0 tags.
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
No reasonable workaround
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Code review and manual testing.
* Give a brief technical overview. Who has reviewed this fix? 
See comment 1
* What is the risk associated with this fix?
low-medium

Comment 5 David Williams

2010-05-28 23:31:15 EDT

Sounds like an important fix. Can you make it using the "old" contentType IDs?

Comment 6 Raghunathan Srinivasan

2010-06-01 11:23:15 EDT

We will redo the patch with existing content type id.

Comment 7 Cameron Bateman

2010-06-01 14:19:25 EDT

Created attachment 170671 [details]
Same patch but with the current content type id used for Facelets.

Comment 8 Cameron Bateman

2010-06-02 11:07:57 EDT

Patch applied to HEAD (3.2RC4).