Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314899

Summary: [tracepoints][run control][non-stop] RunControl actions are enabled when visualizing trace data in non-stop mode
Product: [Tools] CDT Reporter: Marc Khouzam <marc.khouzam>
Component: cdt-debug-dsf-gdbAssignee: Marc Khouzam <marc.khouzam>
Status: RESOLVED FIXED QA Contact: Marc Khouzam <marc.khouzam>
Severity: normal    
Priority: P3 CC: pawel.1.piech
Version: 7.0   
Target Milestone: 7.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Fix marc.khouzam: iplog-

Description Marc Khouzam CLA 2010-05-28 11:32:20 EDT 
In GDBRunControl_7_0 we disable RunControl operations when we are dealing with a post-mortem session or when we are visualizing trace data.

The same logic must be done for GDBRunControl_7_0_NS for visualizing trace data.  I missed this case because the post-mortem check is not needed in that class, since we can not be in non-stop mode for a post-mortem session.
Comment 1 Marc Khouzam CLA 2010-05-29 10:10:16 EDT 
Created attachment 170457 [details]
Fix
Comment 2 Marc Khouzam CLA 2010-05-29 10:52:10 EDT 
This was a minor fix that is pretty safe (copied from another class).
Committed to HEAD.
Comment 3 CDT Genie CLA 2010-05-29 11:23:02 EDT 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 314899: Disable RunControl buttons when looking at trace frames in non-stop mode.

[*] GDBRunControl_7_0_NS.java 1.24 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java?root=Tools_Project&r1=1.23&r2=1.24