Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314873

Summary: Stack trace in Dashboard perspective's Modules view
Product: [Tools] Linux Tools Reporter: Andrew Overholt <overholt>
Component: SystemtapAssignee: anithra <anithra>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: pmuldoon, sgehwolf, thavidur
Version: unspecified   
Target Milestone: 0.6   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch to prevent the stack trace from happening none

Description Andrew Overholt CLA 2010-05-28 09:57:20 EDT 
If I switch to the SystemTap Dashboard perspective, the Modules view has a stack trace in it and a big red error marker with the text "Could not create the view:  String index out of range:  -1".  This needs to be fixed for Helios (ie. in the next two weeks at the very latest).

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.substring(String.java:1949)
	at org.eclipse.linuxtools.systemtap.ui.dashboard.structures.DashboardModuleLocator.getModuleLocations(DashboardModuleLocator.java:83)
	at org.eclipse.linuxtools.systemtap.ui.dashboard.structures.DashboardModuleLocator.getModules(DashboardModuleLocator.java:41)
	at org.eclipse.linuxtools.systemtap.ui.dashboard.views.DashboardModuleBrowserView.generateModuleTree(DashboardModuleBrowserView.java:45)
	at org.eclipse.linuxtools.systemtap.ui.dashboard.views.ModuleView.createPartControl(ModuleView.java:217)
	at org.eclipse.ui.internal.ViewReference.createPartHelper(ViewReference.java:375)
	at org.eclipse.ui.internal.ViewReference.createPart(ViewReference.java:229)
	at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:595)
	at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:313)
	at org.eclipse.ui.internal.ViewPane.setVisible(ViewPane.java:529)
	at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180)
	at org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270)
	at org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65)
	at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:473)
	at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1254)
	at org.eclipse.ui.internal.PartStack.createControl(PartStack.java:666)
	at org.eclipse.ui.internal.PartStack.createControl(PartStack.java:574)
	at org.eclipse.ui.internal.PartSashContainer.createControl(PartSashContainer.java:568)
	at org.eclipse.ui.internal.PerspectiveHelper.activate(PerspectiveHelper.java:272)
	at org.eclipse.ui.internal.Perspective.onActivate(Perspective.java:981)
	at org.eclipse.ui.internal.WorkbenchPage.setPerspective(WorkbenchPage.java:3614)
	at org.eclipse.ui.internal.WorkbenchPage.busySetPerspective(WorkbenchPage.java:1041)
	at org.eclipse.ui.internal.WorkbenchPage.access$16(WorkbenchPage.java:1025)
	at org.eclipse.ui.internal.WorkbenchPage$19.run(WorkbenchPage.java:3715)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkbenchPage.setPerspective(WorkbenchPage.java:3713)
	at org.eclipse.ui.internal.PerspectiveBarContributionItem.select(PerspectiveBarContributionItem.java:124)
	at org.eclipse.ui.internal.PerspectiveBarContributionItem$1.widgetSelected(PerspectiveBarContributionItem.java:93)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1234)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3540)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3159)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:616)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1383)
Comment 1 Andrew Overholt CLA 2010-05-31 11:15:58 EDT 
Sorry, I don't know how this got assigned to Jeff.
Comment 2 Severin Gehwolf CLA 2010-06-02 10:24:13 EDT 
Created attachment 170806 [details]
Patch to prevent the stack trace from happening

It's a project level patch on org.eclipse.linuxtools.systemtap.ui.dashboard and might be a bit ugly but it works.
Comment 3 Andrew Overholt CLA 2010-06-02 10:26:16 EDT 
Anithra, what do you think?  Thanks for the patch, Severin.
Comment 4 Roland Grunberg CLA 2010-06-02 12:15:06 EDT 
Had non-submitted patch for this change. Fixed in Revision 24942.
Comment 5 Andrew Overholt CLA 2010-06-04 16:20:17 EDT 
*** Bug 306893 has been marked as a duplicate of this bug. ***
Comment 6 Andrew Overholt CLA 2010-06-04 16:21:05 EDT 
Verified in EPP build from 20100603 (org.eclipse.linuxtools.systemtap.ui.dashboard_0.3.0.201006021303).
Comment 7 Andrew Overholt CLA 2010-06-04 16:21:13 EDT 
Verifying.