Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314812

Summary: Toggle comment operation not working correct if selected area are part of two lines
Product: z_Archived Reporter: Teodor Kirkov <teodor.k>
Component: PDTAssignee: PHP UI <php.ui-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: gadi, ganoro
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Code selection for Toggle Comment Operation
none
Result after double performed Toggle Comment operation none

Description Teodor Kirkov CLA 2010-05-28 03:53:41 EDT
Build Identifier: 2.2.0.v20100521

Toggled comment cannot be reset by Ctrl+/ if at enter it have selection of multiple lines and one of them are not fully selected

Reproducible: Always

Steps to Reproduce:
Have the following code at Editor:
<?php
class test {
	public function test1(){
		echo "test ";
		echo "test 3 ";
		echo "test 33 ";
	}
}
?>

Select whole line 5 and part of line 6 - see attached Code_selection_screen
After selection Perform Toggle Comment operation by clicking Ctrl+/
After that perform again Ctrl+/

Expected result:
Line comments to be removed from selected area

Actual result:
We have Toggled Comment and the line 4, and doubled line comments at line 5 and 6 - see attached Double_comment_screen
Comment 1 Teodor Kirkov CLA 2010-05-28 03:54:23 EDT
Created attachment 170303 [details]
Code selection for Toggle Comment Operation
Comment 2 Teodor Kirkov CLA 2010-05-28 03:55:17 EDT
Created attachment 170304 [details]
Result after double performed Toggle Comment operation
Comment 3 Zhongwei Zhao CLA 2010-05-30 03:14:34 EDT
fixed in head
Comment 4 Gadi Goldbarg CLA 2010-06-17 08:27:42 EDT
Verified at PDT-2.2.0.v20100616
Toggle comment now works just perfect even have selected only part of one or more lines
Closing this issue...
Thanks

Verified by
Teodor Kirkov
teodor.k@zend.com