Bugzilla – Full Text Bug Listing
| Summary: | 3 missing 'providerNames' in XSL bundles | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | David Williams <david_williams> | ||||||||||
| Component: | wst.xsl | Assignee: | David Carver <d_a_carver> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | David Carver <d_a_carver> | ||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | neil.hauge, raghunathan.srinivasan, thatnitind | ||||||||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
raghunathan.srinivasan: pmc_approved+ thatnitind: pmc_approved? (naci.dai) thatnitind: pmc_approved? (deboer) neil.hauge: pmc_approved+ thatnitind: pmc_approved? (kaloyan) thatnitind: review+ |
||||||||||
| Target Milestone: | 3.2 RC4 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Whiteboard: | PMC_approved | ||||||||||||
| Attachments: |
|
||||||||||||
I believe I corrected org.eclipse.wst.xml.xpath2.processor, org.eclipse.wst.xml.xpath2.processor.tests, and org.eclipse.wst.xsl.exslt.core four days ago. I wasn't aware there was a problem with org.eclipse.wst.xsl.exslt.ui, however. Looks like it's just missing the Bundle-Localization header. Created attachment 170379 [details]
rc3 based build
confirmed several fixed already in RC3. Two to go.
(In reply to comment #2) > Created an attachment (id=170379) [details] > rc3 based build > > confirmed several fixed already in RC3. Two to go. What's the time frame. I might have some time today or this weekend to get them done. For RC4, next Wednesday. While not a functional issue, I think it'd be worth fixing as it effects the "professional appearance" of the software ... if anyone ever looks at that detailed view. (So you'd have one vote :) Okay, I'll work on it this weekend and attach a patch for review. I actually found a total of 3 missing Bundle-Localization entries. I'll attach a patch that corrects this. Created attachment 170455 [details]
Adds missing bundle-localization
Adds missing bundle-localization entries in the manifest.
I've added a couple of people for review and approval. This is a low risk change and just adds some spit and polish to the overall packaging. Looks good to me, except org.eclipse.wst.xml.xpath2.processor.sdk.doc also needed its build.properties file tweaked to include plugin.properties. I'd like to see this fixed. As safe as any rebuild could be, and seeing the keys there in the "installation" dialog looks a little careless or sloppy. Technically, could be said to be required by Sim. Rel. requirements ... but, not sure ... Oh, and I didn't check code ... but, the actual bundle names are missing too, not just providerNames. I assume that's for same reason, but please double check all is well with them (that the keys in manifest match keys in plugin.properties). (In reply to comment #11) > Oh, and I didn't check code ... but, the actual bundle names are missing too, > not just providerNames. I assume that's for same reason, but please double > check all is well with them (that the keys in manifest match keys in > plugin.properties). Yes this was missing because of the missing Bundle-Localization header. Created attachment 170654 [details]
Updated patch to include plugin.properties file
This updates the patch to include the missing plugin.properties file entry in the build.properties file
Releasing on +1/-0. Resolving. |
Created attachment 170294 [details] screen shot showing the 4 In RC2 EPP Packages (both JavaScript and Java EE) there are 4 bundles that shat show the "key" instead of the provider name. The key wasn't literally 'providerName' in each case, but similar. These were the only 4 in the whole package :(