Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314760

Summary: Provide connection / transport framework as API
Product: [WebTools] JSDT Reporter: Michael Rennie <Michael_Rennie>
Component: DebugAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact: Simon Kaegi <simon_kaegi>
Severity: enhancement    
Priority: P3 CC: thatnitind
Version: 3.2   
Target Milestone: 3.3   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
new transport project
none
update for the Crossfire bundle
none
update for Rhino none

Description Michael Rennie CLA 2010-05-27 15:34:23 EDT 
code from HEAD

We have a lot of code in o.e.w.j.d.rhino.debugger.transport that is globally useful for anyone that wants to contribute a JSDI implementation + launching.

For example the experimental crossfire support had to copy all of those classes verbatim to be able to connect over a socket. In 3.3 we should provide an org.eclipse.wst.debug.transport (or similarly named) bundle so this code can be resued.
Comment 1 Michael Rennie CLA 2010-06-30 14:51:21 EDT 
Created attachment 173144 [details]
new transport project

This is the entire new project: org.eclipse.wst.jsdt.debug.transport
Comment 2 Michael Rennie CLA 2010-06-30 14:52:18 EDT 
Created attachment 173145 [details]
update for the Crossfire bundle

This patch updates the crossfire bundle to use the new API
Comment 3 Michael Rennie CLA 2010-06-30 15:41:07 EDT 
Created attachment 173152 [details]
update for Rhino

This patch updates all of the Rhino bundles and the test suite
Comment 4 Michael Rennie CLA 2010-06-30 15:43:04 EDT 
Simon, have a look at the first cut of the API and see what you think.
Comment 5 Simon Kaegi CLA 2010-07-20 12:50:29 EDT 
The direction is right and a quick review didn't reveal anything that surprised me very much. The new transport bundle is a bit restricted and must run in non-OSGi environments because it will be used on the debugger side when folk want to debug a standalone rhino instance.

I think you're fine to check your changes in and we can work it into shape if needed.
Comment 6 Michael Rennie CLA 2010-07-20 15:30:52 EDT 
applied patches to HEAD with minor updates:

1. removed all reference to core.runtime from the new transport bundle as it needs to be usable without eclipse at all.

2. updated some doc

Also updated the jsdt.feature and the map file for the new bundle, which has initially been tagged as v201007201421

Marking this bug fixed. Any subsequent updates / bugs can be in their own bug reports.