Bugzilla – Full Text Bug Listing
| Summary: | Malformed error messages returned from org.eclipse.jdt.core.JavaConventions APIs. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Paul Slauenwhite <paulslau> | ||||
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
| Status: | CLOSED WORKSFORME | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Olivier_Thomann | ||||
| Version: | 3.6 | Keywords: | needinfo | ||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Olivier, will this defect be deferred to Eclipse 3.6.1/2? Probably. (In reply to comment #0) > 1) org.eclipse.jdt.core.JavaConventions.validatePackageName("&", "1.5", "1.5"): > ". is not a valid Java identifier. I tried this and I got: '&' is not a valid Java identifier as the status message. > 2) org.eclipse.jdt.core.JavaConventions.validateJavaTypeName("&", "1.5", > "1.5"): The type name ". is not a valid identifier. I get: The type name '&' is not a valid identifier Not sure what you did to get your error messages. What build are you using ? Created attachment 170417 [details]
Regression tests
This adds two regression tests and shows that the "right" messages are returned.
(In reply to comment #4) > What build are you using ? We are using Eclipse 3.6 RC2 (Windows XP). Could you please provide a setup so that I can reproduce it the way you get it? I don't understand why your error messages would be different. Are you displaying the message in HTML or using a specific encoding ? Hi, I would need more info on how you get these wrong messages. Right now simply calling the API returns expected error messages. Removing target as I still didn't get any steps to reproduce. Any update on how to reproduce these errors ? No answer means I'll close as WORKSFORME. Apologies for the late reply (vacation). After a closer inspection of the code, the error messages returned from these APIs are in fact correct. The original symptom is caused by the org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperation not displaying the error message correctly in the wizard. Closing. |
Malformed error messages returned from org.eclipse.jdt.core.JavaConventions APIs. For example: 1) org.eclipse.jdt.core.JavaConventions.validatePackageName("&", "1.5", "1.5"): ". is not a valid Java identifier. 2) org.eclipse.jdt.core.JavaConventions.validateJavaTypeName("&", "1.5", "1.5"): The type name ". is not a valid identifier.