Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314718

Summary: Compilation regression on Java Discoverer based on CDO
Product: [Modeling] MoDisco Reporter: Fabien Giquel <fabien.giquel>
Component: TechnologiesAssignee: Fabien Giquel <fabien.giquel>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: barbier.gabriel, gdupe, hugo.bruneliere, Kenn.Hussey, modisco.web-inbox, nicolas.bros
Version: 0.8.0Flags: fabien.giquel: helios+
Kenn.Hussey: pmc_approved+
barbier.gabriel: review+
Target Milestone: 0.8.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
patch for java discoverer benchmark none

Description Fabien Giquel CLA 2010-05-27 12:42:44 EDT 
Created attachment 170226 [details]
patch

The MoDisco org.eclipse.gmt.modisco.java.discoverer.cdo component uses the org.eclipse.emf.cdo component.
A method signature has recently evolved on one non-internal CDO class : org.eclipse.emf.cdo.transaction.CDOUserTransaction#commit.
This change is described in bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=314455

We have to take in account this change. So here is a patch which must be integrated in Helios RC3.
Comment 1 Kenn Hussey CLA 2010-05-27 15:54:51 EDT 
I approve of this change because you obviously can't ship with a compile error. I personally disapprove of the change for bug 314455, but I guess that's water under the bridge at this point...
Comment 2 Fabien Giquel CLA 2010-05-28 06:06:59 EDT 
Created attachment 170324 [details]
patch for java discoverer benchmark

Completing the patch for one class of another MoDisco project which also uses the CDOUserTransaction api.
Comment 3 Fabien Giquel CLA 2010-05-28 10:50:40 EDT 
I have committed the patch on branch 0_8_0.
Comment 4 Fabien Giquel CLA 2010-05-31 11:19:46 EDT 
The 0.8.0 last integration build was successful.
Comment 5 Hugo Bruneliere CLA 2010-10-04 13:17:33 EDT 
The patch has been successfully applied.