Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314591

Summary:

Refactoring: Remove Unreferenced Labels - CQ 4178 (approved)

Product:

[Tools] PTP

Reporter:

Mariano Mendez <marianomendez>

Component:

Photran.Refactoring Engine

Assignee:

ehuq24

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

com-eclipse-dot-org

Version:

unspecified

Target Milestone:

7.0

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
the patch	com-eclipse-dot-org: iplog+
compliant with Eclipse Helios rc2	none
legal issue fixed	none
Revised patch - changed Reindenter package, added replace to test case class	none
Marker based test suite for for Remove Unreferenced Labels refactoring	none
(NEW) Marker-based test suite for Remove Unreferenced Label refactoring	g.watson: iplog+

Description Mariano Mendez

2010-05-26 20:24:56 EDT

Build Identifier: I20100513-1500

This refactoring removes the labels that are not longer referenced by any statement. If the statement is a Continue statement , the Continue stmt is removed from the code.


Reproducible: Always

Comment 1 Mariano Mendez

2010-05-26 20:26:36 EDT

Created attachment 170125 [details]
the patch

Comment 2 Jeffrey Overbey

2010-05-27 16:26:44 EDT

Thanks, Mariano.  Can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?

Comment 3 Mariano Mendez

2010-05-27 17:25:13 EDT

I confirm  that 

 
 1. I wrote 100% of the code without incorporating content from elsewhere or
 relying on the intellectual property of others,
 
 2. I have the right to contribute the code to Eclipse, and
 
 3. I have included the EPL license header in all source files


Mariano Mendez

Comment 4 Jeffrey Overbey

2010-05-27 18:16:05 EDT

CQ 4178 submitted

Comment 5 Mariano Mendez

2010-06-04 18:26:30 EDT

Created attachment 171185 [details]
compliant with Eclipse Helios rc2

Comment 6 Jeffrey Overbey

2010-06-16 17:15:06 EDT

Hi Mariano,

I've been in contact with the IP team.  They will be contacting Alejandra regarding copyright issues.

They would like you to make the following change:

1. The last line should read "Mariano Mendez - Initial API and implementation"

Please revise the patch accordingly, and I'll submit the revised version to the IP team.  Thanks.

Comment 7 Mariano Mendez

2010-06-17 21:22:32 EDT

Created attachment 172181 [details]
legal issue fixed

Comment 8 Jeffrey Overbey

2010-06-18 17:47:27 EDT

Thanks.  I attached the revised patch to the CQ.  Sharon will process the CQ as soon as she receives confirmation from your University that the copyright belongs to you.

Comment 9 Jeffrey Overbey

2010-07-06 17:07:04 EDT

The CQ was approved.  I will try to get this into CVS soon.

Comment 10 Jeffrey Overbey

2010-07-14 18:09:06 EDT

Created attachment 174356 [details]
Revised patch - changed Reindenter package, added replace to test case class

Comment 11 Jeffrey Overbey

2010-07-14 18:10:24 EDT

Esfar, could you please convert the test suite for this refactoring to be marker-based and then attach a revised patch?  It looks like he expects the second test case to fail its initial(?) precondition check, and the other two should pass.  Thanks.

Comment 12 ehuq24

2010-07-15 14:24:07 EDT

Created attachment 174432 [details]
Marker based test suite for for Remove Unreferenced Labels refactoring

Comment 13 ehuq24

2010-07-15 14:27:12 EDT

Quick note, I'm not sure at the moment as to why test case #2 does not seem to work. It seems to expect an initial precondition failure, but I can't see why one would occur.

Also, test case #3 no longer seems to be refactored in marker-based style.

Comment 14 ehuq24

2010-07-15 17:16:38 EDT

Created attachment 174451 [details]
(NEW) Marker-based test suite for Remove Unreferenced Label refactoring

Correct patch. Issues in the last patch resulted from me not separating test files into individual folders.

Comment 15 Jeffrey Overbey

2010-07-19 17:08:52 EDT

Thanks.  Esfar, for your test suite code, can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others (except for code from Mariano's original tests),

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?

Comment 16 ehuq24

2010-07-19 17:14:58 EDT

(In reply to comment #15)
> Thanks.  Esfar, for your test suite code, can you please confirm that
> 
> 1. you wrote 100% of the code without incorporating content from elsewhere or
> relying on the intellectual property of others (except for code from Mariano's
> original tests),
> 
> 2. you have the right to contribute the code to Eclipse, and
> 
> 3. you have included the EPL license header in all source files?

Yes,

1. I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others (except for code from Mariano's original tests),

2. I have the right to contribute code to Eclipse, and

3. I have included the EPL license header in all source files

Comment 17 Jeffrey Overbey

2010-07-19 17:24:01 EDT

Committed to CVS HEAD.  Thanks, Mariano and Esfar.